-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Cross build for Scala3 #1012
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good
core/src/main/scala/akka/persistence/cassandra/query/EventsByPersistenceIdStage.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/akka/persistence/cassandra/query/scaladsl/CassandraReadJournal.scala
Outdated
Show resolved
Hide resolved
Build seems fine, just docs link validator fails with:
@johanandren Maybe we ignore that error for now and make it not-fail once released? |
Link validator is not my best friend in general, yes, we can ignore it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lookin' good!
core/src/main/scala/akka/persistence/cassandra/EventsByTagMigration.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/akka/persistence/cassandra/query/CassandraReadJournalProvider.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/akka/persistence/cassandra/query/EventsByPersistenceIdStage.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/akka/persistence/cassandra/EventsByTagStressSpec.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/akka/persistence/cassandra/RetriesSpec.scala
Outdated
Show resolved
Hide resolved
"https://doc.akka.io/api/akka-persistence-cassandra/current/") | ||
++ { | ||
if (scalaBinaryVersion.value.startsWith("3")) { | ||
Seq("-skip-packages:akka.pattern") // different usage in scala3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, that's the new syntax 👍 In management I completely dropped it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.