Mqtt retained feature #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
requested changes
Jun 28, 2023
...-mqtt/src/test/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/ConnectionIT.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttServerFactory.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttServerFactory.java
Outdated
Show resolved
Hide resolved
...y/zilla/specs/binding/mqtt/streams/network/disconnect.close.subscribe.and.publish/server.rpt
Outdated
Show resolved
Hide resolved
...y/zilla/specs/binding/mqtt/streams/network/disconnect.close.subscribe.and.publish/client.rpt
Outdated
Show resolved
Hide resolved
.../io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSubscribeFactory.java
Outdated
Show resolved
Hide resolved
.../io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSubscribeFactory.java
Outdated
Show resolved
Hide resolved
.../io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSubscribeFactory.java
Outdated
Show resolved
Hide resolved
.../io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSubscribeFactory.java
Outdated
Show resolved
Hide resolved
.../io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSubscribeFactory.java
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Jul 7, 2023
.../main/java/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/MqttKafkaConfiguration.java
Outdated
Show resolved
Hide resolved
...t/java/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/MqttKafkaConfigurationTest.java
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaPublishProxyIT.java
Outdated
Show resolved
Hide resolved
...ing-mqtt.spec/src/main/java/io/aklivity/zilla/specs/binding/mqtt/internal/MqttFunctions.java
Show resolved
Hide resolved
...y/zilla/specs/binding/mqtt/streams/network/disconnect.close.subscribe.and.publish/client.rpt
Outdated
Show resolved
Hide resolved
.../io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSubscribeFactory.java
Outdated
Show resolved
Hide resolved
.../io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSubscribeFactory.java
Outdated
Show resolved
Hide resolved
.../io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSubscribeFactory.java
Outdated
Show resolved
Hide resolved
.../io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSubscribeFactory.java
Outdated
Show resolved
Hide resolved
.../io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaSubscribeFactory.java
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Jul 12, 2023
...qtt-kafka.spec/src/test/java/io/aklivity/zilla/specs/binding/mqtt/kafka/streams/KafkaIT.java
Outdated
Show resolved
Hide resolved
...va/io/aklivity/zilla/runtime/binding/mqtt/kafka/internal/stream/MqttKafkaPublishProxyIT.java
Outdated
Show resolved
Hide resolved
...lla/specs/binding/mqtt/streams/application/disconnect.after.subscribe.and.publish/client.rpt
Show resolved
Hide resolved
...y/zilla/specs/binding/mqtt/streams/network/disconnect.after.subscribe.and.publish/server.rpt
Outdated
Show resolved
Hide resolved
...tt.spec/src/test/java/io/aklivity/zilla/specs/binding/mqtt/streams/network/ConnectionIT.java
Outdated
Show resolved
Hide resolved
...-mqtt/src/test/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/ConnectionIT.java
Outdated
Show resolved
Hide resolved
| this.delegate = new KafkaProxy(originId, resolvedId, this); | ||
| this.keyBuffer = new UnsafeBuffer(new byte[bufferCapacity]); | ||
| this.headerIntValueBuffer = new UnsafeBuffer(new byte[bufferCapacity]); | ||
| this.kafkaHeadersBuffer = new UnsafeBuffer(new byte[bufferCapacity]); |
There was a problem hiding this comment.
This is a lot of buffer allocation to use per stream, let's discuss.
| this.retainedSubscriptionIds = new IntArrayList(); | ||
| this.retainedSubscriptions = new ArrayList<>(); | ||
| this.retainAsPublished = new Long2ObjectHashMap<>(); | ||
| this.filtersBuffer = new UnsafeBuffer(new byte[bufferCapacity]); |
There was a problem hiding this comment.
Let's review this per-stream buffer too.
jfallows
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.