Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API abstraction for SchemaRegistry in Zilla #311

Merged
merged 28 commits into from
Sep 10, 2023
Merged

API abstraction for SchemaRegistry in Zilla #311

merged 28 commits into from
Sep 10, 2023

Conversation

ankitk-me
Copy link
Contributor

@ankitk-me ankitk-me commented Jul 20, 2023 •
edited
Loading

fixes #310

jfallows
jfallows requested changes Jul 27, 2023
View reviewed changes
runtime/engine/src/main/java/io/aklivity/zilla/runtime/engine/EngineContext.java Outdated Show resolved Hide resolved
...e/engine/src/main/java/io/aklivity/zilla/runtime/engine/internal/registry/DispatchAgent.java Outdated Show resolved Hide resolved
runtime/engine/src/main/moditect/module-info.java Outdated Show resolved Hide resolved
.../test/resources/META-INF/services/io.aklivity.zilla.runtime.engine.catalog.CatalogFactorySpi Outdated Show resolved Hide resolved
...ain/scripts/io/aklivity/zilla/specs/binding/kafka/config/client.options.schema.registry.yaml Outdated Show resolved Hide resolved
...ain/scripts/io/aklivity/zilla/specs/binding/kafka/config/client.options.schema.registry.yaml Outdated Show resolved Hide resolved
specs/engine.spec/src/main/scripts/io/aklivity/zilla/specs/engine/schema/engine.schema.json Outdated Show resolved Hide resolved
specs/engine.spec/src/main/scripts/io/aklivity/zilla/specs/engine/schema/engine.schema.json Outdated Show resolved Hide resolved
jfallows
jfallows requested changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@jfallows jfallows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good - but we need to verify the abstraction with a Kafka-side implementation that makes use of the CatalogHandler API.

...a.spec/src/main/scripts/io/aklivity/zilla/specs/binding/kafka/schema/kafka.schema.patch.json Outdated Show resolved Hide resolved
...a.spec/src/main/scripts/io/aklivity/zilla/specs/binding/kafka/schema/kafka.schema.patch.json Outdated Show resolved Hide resolved
...a.spec/src/main/scripts/io/aklivity/zilla/specs/binding/kafka/schema/kafka.schema.patch.json Show resolved Hide resolved
...a.spec/src/main/scripts/io/aklivity/zilla/specs/binding/kafka/schema/kafka.schema.patch.json Show resolved Hide resolved
runtime/engine/src/main/java/io/aklivity/zilla/runtime/engine/catalog/CatalogHandler.java Outdated Show resolved Hide resolved
@ankitk-me ankitk-me marked this pull request as draft August 9, 2023 02:25
@ankitk-me ankitk-me self-assigned this Aug 9, 2023
jfallows
jfallows requested changes Aug 9, 2023
View reviewed changes
.../java/io/aklivity/zilla/runtime/binding/kafka/internal/config/KafkaCatalogConfigAdapter.java Outdated Show resolved Hide resolved
.../java/io/aklivity/zilla/runtime/binding/kafka/internal/config/KafkaCatalogConfigAdapter.java Outdated Show resolved Hide resolved
.../java/io/aklivity/zilla/runtime/binding/kafka/internal/config/KafkaOptionsConfigAdapter.java Outdated Show resolved Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/kafka/internal/config/KafkaSerDeConfig.java Outdated Show resolved Hide resolved
...in/java/io/aklivity/zilla/runtime/binding/kafka/internal/config/KafkaSerDeConfigHandler.java Outdated Show resolved Hide resolved
...in/java/io/aklivity/zilla/runtime/binding/kafka/internal/config/KafkaTopicCatalogConfig.java Outdated Show resolved Hide resolved
.../io/aklivity/zilla/runtime/binding/kafka/internal/config/KafkaTopicCatalogConfigHandler.java Outdated Show resolved Hide resolved
...in/java/io/aklivity/zilla/runtime/binding/kafka/internal/stream/KafkaClientFetchFactory.java Outdated Show resolved Hide resolved
...fka/src/test/java/io/aklivity/zilla/runtime/binding/kafka/internal/stream/ClientFetchIT.java Outdated Show resolved Hide resolved
runtime/engine/src/main/java/io/aklivity/zilla/runtime/engine/catalog/CatalogHandler.java Outdated Show resolved Hide resolved
jfallows
jfallows requested changes Aug 16, 2023
View reviewed changes
...rc/main/java/io/aklivity/zilla/runtime/binding/kafka/internal/config/KafkaBindingConfig.java Outdated Show resolved Hide resolved
...rc/main/java/io/aklivity/zilla/runtime/binding/kafka/internal/config/KafkaBindingConfig.java Outdated Show resolved Hide resolved
...n/java/io/aklivity/zilla/runtime/binding/kafka/internal/config/KafkaTopicKeyValueConfig.java Outdated Show resolved Hide resolved
.../java/io/aklivity/zilla/runtime/binding/kafka/internal/validator/StringValidatorFactory.java Outdated Show resolved Hide resolved
...c/main/java/io/aklivity/zilla/runtime/binding/kafka/internal/validator/ValidatorFactory.java Outdated Show resolved Hide resolved
...pec/src/main/scripts/io/aklivity/zilla/specs/binding/kafka/config/cache.options.catalog.yaml Outdated Show resolved Hide resolved
...rc/main/java/io/aklivity/zilla/runtime/binding/kafka/internal/validator/StringValidator.java Outdated Show resolved Hide resolved
...rc/main/java/io/aklivity/zilla/runtime/binding/kafka/internal/validator/StringValidator.java Outdated Show resolved Hide resolved
...rc/main/java/io/aklivity/zilla/runtime/binding/kafka/internal/validator/StringValidator.java Outdated Show resolved Hide resolved
...rc/main/java/io/aklivity/zilla/runtime/binding/kafka/internal/validator/StringValidator.java Outdated Show resolved Hide resolved
jfallows
jfallows requested changes Aug 22, 2023
View reviewed changes
...a.spec/src/main/scripts/io/aklivity/zilla/specs/binding/kafka/schema/kafka.schema.patch.json Outdated Show resolved Hide resolved
...a.spec/src/main/scripts/io/aklivity/zilla/specs/binding/kafka/schema/kafka.schema.patch.json Outdated Show resolved Hide resolved
...c/src/main/scripts/io/aklivity/zilla/specs/binding/kafka/config/cache.options.type.avro.yaml Outdated Show resolved Hide resolved
...src/test/java/io/aklivity/zilla/runtime/engine/test/internal/catalog/TestCatalogHandler.java Outdated Show resolved Hide resolved
...src/test/java/io/aklivity/zilla/runtime/engine/test/internal/catalog/TestCatalogHandler.java Outdated Show resolved Hide resolved
...afka/src/main/java/io/aklivity/zilla/runtime/binding/kafka/internal/validator/Validator.java Outdated Show resolved Hide resolved
.../main/java/io/aklivity/zilla/runtime/binding/kafka/internal/config/KafkaTopicValidators.java Outdated Show resolved Hide resolved
...rc/main/java/io/aklivity/zilla/runtime/binding/kafka/internal/validator/StringValidator.java Outdated Show resolved Hide resolved
...rc/main/java/io/aklivity/zilla/runtime/binding/kafka/internal/config/KafkaBindingConfig.java Outdated Show resolved Hide resolved
...rc/main/java/io/aklivity/zilla/runtime/binding/kafka/internal/config/KafkaBindingConfig.java Outdated Show resolved Hide resolved
jfallows
jfallows requested changes Aug 29, 2023
View reviewed changes
runtime/binding-kafka/labels Outdated Show resolved Hide resolved
runtime/binding-kafka/pom.xml Outdated Show resolved Hide resolved
.../java/io/aklivity/zilla/runtime/binding/kafka/internal/validator/config/ValidatorConfig.java Outdated Show resolved Hide resolved
runtime/engine/src/main/java/io/aklivity/zilla/runtime/engine/catalog/CatalogHandler.java Outdated Show resolved Hide resolved
...rc/main/java/io/aklivity/zilla/runtime/binding/kafka/internal/config/KafkaCatalogConfig.java Outdated Show resolved Hide resolved
...rc/main/java/io/aklivity/zilla/runtime/binding/kafka/internal/validator/StringValidator.java Outdated Show resolved Hide resolved
...rc/main/java/io/aklivity/zilla/runtime/binding/kafka/internal/validator/StringValidator.java Outdated Show resolved Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/kafka/internal/validator/LongValidator.java Outdated Show resolved Hide resolved
...c/main/java/io/aklivity/zilla/runtime/binding/kafka/internal/validator/IntegerValidator.java Outdated Show resolved Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/kafka/internal/validator/AvroValidator.java Outdated Show resolved Hide resolved
jfallows
jfallows requested changes Sep 5, 2023
View reviewed changes
...c/main/java/io/aklivity/zilla/runtime/binding/kafka/internal/validator/IntegerValidator.java Outdated Show resolved Hide resolved
...rc/main/java/io/aklivity/zilla/runtime/binding/kafka/internal/validator/StringValidator.java Show resolved Hide resolved
...src/test/java/io/aklivity/zilla/runtime/engine/test/internal/catalog/TestCatalogContext.java Outdated Show resolved Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/kafka/internal/validator/AvroValidator.java Outdated Show resolved Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/kafka/internal/validator/AvroValidator.java Outdated Show resolved Hide resolved
...in/java/io/aklivity/zilla/runtime/binding/kafka/internal/stream/KafkaCacheServerFactory.java Outdated Show resolved Hide resolved
...in/java/io/aklivity/zilla/runtime/binding/kafka/internal/stream/KafkaCacheClientFactory.java Outdated Show resolved Hide resolved
@ankitk-me ankitk-me marked this pull request as ready for review September 10, 2023 16:39
@jfallows jfallows merged commit 048e2e8 into aklivity:feature/schema-registry Sep 10, 2023
0 of 3 checks passed
@ankitk-me ankitk-me deleted the schemaRegistry branch September 26, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfallows jfallows jfallows approved these changes

Assignees

@ankitk-me ankitk-me

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankitk-me @jfallows