Json Validator and Inline Schema fix #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
requested changes
Sep 25, 2023
| @@ -27,6 +27,7 @@ public class InlineOptionsConfigAdapter implements OptionsConfigAdapterSpi, Json | |||
| private static final String SUBJECTS_NAME = "subjects"; | |||
| private static final String VERSION_NAME = "version"; | |||
| private static final String SCHEMA_NAME = "schema"; | |||
| private static final String LATEST = "latest"; | |||
There was a problem hiding this comment.
Use VERSION_DEFAULT as constant name instead of LATEST.
| @@ -26,6 +26,7 @@ public class SchemaConfigAdapter implements JsonbAdapter<SchemaConfig, JsonObjec | |||
| private static final String STRATEGY_NAME = "strategy"; | |||
| private static final String SUBJECT_NAME = "subject"; | |||
| private static final String VERSION_NAME = "version"; | |||
| private static final String LATEST = "latest"; | |||
There was a problem hiding this comment.
Use VERSION_DEFAULT for constant name.
jfallows
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.