Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extraEnv to Deployment in the helm chart #511

Merged
merged 2 commits into from
Oct 21, 2023
Merged

Add extraEnv to Deployment in the helm chart #511

merged 2 commits into from
Oct 21, 2023

Conversation

attilakreiner
Copy link
Contributor

@attilakreiner attilakreiner commented Oct 13, 2023 •
edited
Loading

Description

Add extraEnv option to offer an easier way of overriding environment variables.

Fixes #520

@vordimous
Copy link
Contributor

This LGTM, IT doesn't break any existing values.yaml that have implemented a workaround and removes the env attribute from the default values.yaml meaning new users will see and use extraEnv.

@jfallows
Copy link
Contributor

@attilakreiner this looks great!

Please file a zilla enhancement issue indicating the env syntax we have now (weird escaping) and the improved extraEnv syntax we want to support without needing the same escaping (implemented by this change).

Then add the issue number to Fixes # in the description above to link this PR to the issue so it closes automatically when this PR is merged.

@attilakreiner attilakreiner marked this pull request as ready for review October 16, 2023 16:15
@jfallows jfallows merged commit ded98ea into aklivity:develop Oct 21, 2023
2 of 5 checks passed
ankitk-me pushed a commit to ankitk-me/zilla that referenced this pull request Oct 25, 2023
@attilakreiner @ankitk-me
Add extraEnv to Deployment in the helm chart (aklivity#511)
bb9fb56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfallows jfallows jfallows approved these changes

@vordimous vordimous vordimous approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support extraEnv in helm chart
3 participants
@attilakreiner @vordimous @jfallows