Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT 3.1.1 support - specs #570

Merged
merged 6 commits into from
Nov 21, 2023
Merged

Conversation

bmaidics
Copy link
Contributor

No description provided.

@bmaidics bmaidics linked an issue Nov 13, 2023 that may be closed by this pull request
@@ -781,7 +781,7 @@ private int decodeConnack(
{
int reasonCode = SUCCESS;

final MqttConnackFW connack = mqttConnackRO.tryWrap(buffer, offset, limit);
final MqttConnackV5FW connack = mqttConnackRO.tryWrap(buffer, offset, limit);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field does not need to change as it is local to the method, but the method name will need to change to decodeConnackV5 though.

Similar for other decode methods.

@jfallows jfallows merged commit 8823b7a into aklivity:feature/mqtt-kafka Nov 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support mqtt protocol v3.1.1
2 participants