MQTT 3.1.1 implementation #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
reviewed
Nov 28, 2023
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttClientFactory.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttClientFactory.java
Outdated
Show resolved
Hide resolved
...ty/zilla/specs/binding/mqtt/streams/network/v5/session.connect.payload.fragmented/server.rpt
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Nov 29, 2023
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttClientFactory.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttServerFactory.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttServerFactory.java
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttServerFactory.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttServerFactory.java
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Nov 30, 2023
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttServerFactory.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttServerFactory.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttServerFactory.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttServerFactory.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttServerFactory.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttServerFactory.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttServerFactory.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttServerFactory.java
Outdated
Show resolved
Hide resolved
jfallows
requested changes
Nov 30, 2023
There was a problem hiding this comment.
We need separate decodePacketTypeV4 and decodePacketTypeV5 decoders.
Then decodeInitialType should decode the generic connect fields to extract the version and switch to the either decodePacketTypeV4 or decodePacketTypeV5.
There should be no need to keep checking the version in decodePacketTypeXX methods.
Suggest having an Int2ObjectHashMap<MqttServerDecoder> from version to decodePacketTypeXX methods.
Then at the end of a decodeXXX method that is identical for both versions, instead of setting the decoder to decodePacketType you can set it to decodePacketTypeByVersion.get(server.version) instead.
For decodeXXX methods that are version specific, they can set the next decoder to decodePacketTypeV4 or decodePacketTypeV5 explicitly.
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttServerFactory.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/mqtt/internal/stream/MqttServerFactory.java
Outdated
Show resolved
Hide resolved
jfallows
reviewed
Nov 30, 2023
jfallows
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.