Combined #18
Merged
Combined #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It took me a bit to understand that s.start isn't actually used to persist anything. Using a local variable for this seems simpler.
Just use ints pointing into the large byte slice. Mmap() creates two `[]byte`s per key value pair. This creates significant work for the garbage collector which has to scan through all of these in each mark phase. For my 2.7M keys, it adds 5.4M pointers to be scanned. By just using integers for offsets the garbage collector can ignore it completely. This does trade off some more work for the Builder which has to append all the keys+values into a single byte slice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.