Allowing seeding the builder to get reproducible data #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm using this to get the byte-for-byte same result if the input is the same, so my rsync-like tool doesn't need to retransmit the data.
|
Friendly ping @alecthomas |
alecthomas
reviewed
Sep 4, 2024
| @@ -41,13 +41,21 @@ func (b bucketVector) Swap(i, j int) { b[i], b[j] = b[j], b[i] } | |||
| type CHDBuilder struct { | |||
| keys [][]byte | |||
| values [][]byte | |||
| seed int64 | |||
| seeded bool | |||
| } | |||
|
|
|||
| // Create a new CHD hash table builder. | |||
| func Builder() *CHDBuilder { | |||
| return &CHDBuilder{} | |||
There was a problem hiding this comment.
I think this needs to be updated to set seed to a random value?
There was a problem hiding this comment.
Given that the constructor just allocates an empty struct, I wasn't sure if everyone used the constructor or whether some users just allocate themselves.
So I went with an extra boolean and did the seeding when needed rather than up front.
There was a problem hiding this comment.
That's a better idea than my one, thanks!
|
Apologies for the delay! |
alecthomas
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this to get the byte-for-byte same result if the input is the same, so my rsync-like tool doesn't need to retransmit the data.
also switch to
rand.Uint64()which is probably a little cheaper.