Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target details #56

Merged
merged 14 commits into from
Jun 5, 2024
Merged

Target details #56

merged 14 commits into from
Jun 5, 2024

Conversation

Demurest
Copy link
Contributor

@Demurest Demurest commented Jun 4, 2024

Summary of the changes

  • Se crearon diferentes componentes entre ellos la LightCurveCard, MatchesList, TargetCard.
  • Se modificó el componente Overview.vue y OverviewLayout.vue.
  • Se adaptó el test Overview.spec.ts.

Observations

If the change is BREAKING, please give more details about the breaking changes

Components that need updates and steps to follow

About this PR:

  • [ X] You added the necessary documentation for the team to understand your work.
  • You linked this PR to the corresponding issue or user story.
  • Your changes fulfill the Definition of Done of the issue or user story.
  • Your changes were tested with manual testing before being submitted.
  • Your changes were tested with automatic unit tests.
  • Your changes were tested with automatic integration tests.

Screensshots

@Demurest Demurest requested a review from HectorxH June 4, 2024 13:26
@Demurest Demurest self-assigned this Jun 4, 2024
HectorxH
HectorxH requested changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@HectorxH HectorxH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un detalle pequeño nomas, el resto se ve bien!

src/ui/components/watchlist/TargetList.vue Outdated Show resolved Hide resolved
src/ui/components/watchlist/__tests__/Overview.spec.ts Outdated Show resolved Hide resolved
@Demurest Demurest requested a review from HectorxH June 5, 2024 15:06
HectorxH
HectorxH approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@HectorxH HectorxH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Demurest Demurest merged commit 803ab8d into develop Jun 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HectorxH HectorxH HectorxH approved these changes

Assignees

@Demurest Demurest

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Demurest @HectorxH