Fix up small caps h with breve below #435
Conversation
|
Perfect, thank you so much! |
|
Okay great. I need to work through the other styles before I merge this; so far only Serif Regular has been addressed. Feel free to use the test builds for now. I might ping you again for a quick sanity check when all the styles are ready, but I'm glad to hear this is on the right track. |
|
@vjeffcott Is there any immanent need for Sans faces to be fixed too? I've gotten through all six Serif styles (Regular, Semibold, and Bold weights in Roman and Italic styles) and I think we're good to go across that family. I can to Sans too but honestly the mark positioning is so bad there it would be a bit of a rabbit hole fixing unrelated issues. If Serif is the immanent need I'll go ahead and merge this for now and hope for a more comprehensive overhaul eventually. |
No, I'm only using Serif for this project. Thank you very much for your help! |
|
@vjeffcott Great. When I get a chance I'll work on merging this, but I'm just a touch concerned the mark positioning could have thrown off some other uses of breve below on other glyphs. Until I have time to run some QA on this and make sure nothing else regressed I'm going to hold off. In the mean time please do keep using the builds from this PR that have all the Serif faces covered and let me know if there are any issues. |
|
The only other mark in use on these glyphs using the below marker seems to be the dot-below and the positioning seems okay there. The only other fix I added since the last round is applying the same mark alignment used for the smallcaps h glyph to the U+029C small capital h glyph across all the families. |
Fixes #432
Hey @vjeffcott can you give this a spin? You can download artifacts from the ‘Checks’ tab of this PR.