Add system packages and an app for Go #663
Conversation
cmd/system/system.go
Outdated
| Use: "system", | ||
| Short: "System apps", | ||
| Long: `Apps for systems.`, | ||
| Aliases: []string{"v"}, |
There was a problem hiding this comment.
I copied from the venafi app so we can change that to s
| func UntarNested(r io.Reader, dir string) error { | ||
| return untarNested(r, dir) | ||
| } | ||
|
|
||
| func untarNested(r io.Reader, dir string) (err error) { |
There was a problem hiding this comment.
Should we move this functions under pkg/archive/untar.go?
I think it makes much more sense.
There was a problem hiding this comment.
No I don't see any reason to have one file for this.
| command.RunE = func(cmd *cobra.Command, args []string) error { | ||
| installPath, _ := cmd.Flags().GetString("path") | ||
| version, _ := cmd.Flags().GetString("version") | ||
| fmt.Printf("Installing Go to %s\n", installPath) |
There was a problem hiding this comment.
Should we introduce --quiet flag as we did earlier for binary downloads?
There was a problem hiding this comment.
I'm going to keep things verbose for the preview stages, to make it simpler / less work for everyone.
Then we can come back and fine tune.
Part of #654, tested on an Intel x86_64 machine. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
alexellis
force-pushed
the
openfaasltd/add-system-package-go
branch
from
2ee281b
to
5a2392e
Compare
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
|
@Shikachuu do you want to have a go at the containerd recipe and prometheus next? @richardcase volunteered to take the firecracker CLI I didn't use a Go template in this Go app, but if we need it we can bring that back in for the additional apps we're working with. |
|
@alexellis sure I'll play around with containerd! |
Description
Add system packages and an app for Go
Motivation and Context
#654
How Has This Been Tested?
Types of changes
Documentation
I've updated the README
Checklist: