fix(ie11): preact-compat algolia fork with #423 #2471
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 11, 2017 11:36
<a name=2.2.1-beta.0></a> ## [2.2.1-beta.0](v2.2.0...v2.2.1-beta.0) (2017-10-11) ### Bug Fixes * **connectRangeSlider:** only clear the refinement on the current attribute ([#2459](#2459)) ([7cebf58](7cebf58)) * **ie11:** peract-compat algolia fork with [#423](#423) ([c22e436](c22e436)) * **menuSelect:** select in userCssClasses ([#2455](#2455)) ([0eb3dc8](0eb3dc8)) * **menuSelect:** use preact instead of React ([#2460](#2460)) ([35ccae8](35ccae8)) * **test:** correctly reset the wired dependency ([#2461](#2461)) ([1f7f4ed](1f7f4ed))
|
Deploy preview ready! Built with commit ee13d6f https://deploy-preview-2471--algolia-instantsearch.netlify.com |
iam4x
reviewed
Oct 11, 2017
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "instantsearch.js", | |||
| "version": "2.2.0", | |||
| "version": "2.2.1-beta.0", | |||
There was a problem hiding this comment.
this should only change with the build script
There was a problem hiding this comment.
That's alright, since it's gonna be 2.2.1 anyway.
iam4x
approved these changes
Oct 11, 2017
|
Failling on the commit: |
|
Well it seems that it might not fix what is supposed to. Will check that tomorrow. |
bobylito
changed the title
|
Actually the library works with IE11. No need for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix an issue of preact-compat on IE11. It uses an algolia fork of preact-compat, that we need to replace once the new version is out (3.17.1 or 3.18.0)