Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): fix height of pagination #2641

Merged
merged 2 commits into from
Dec 29, 2017
Merged

Conversation

bobylito
Copy link
Contributor

The height was super wild by default.

@algobot
Copy link
Contributor

algobot commented Dec 28, 2017

Deploy preview ready!

Built with commit 09aabf9

https://deploy-preview-2641--algolia-instantsearch.netlify.com

@Haroenv
Copy link
Contributor

Haroenv commented Dec 28, 2017

The Argos changes look fine to me, where can I test the change as simple as possible?

@bobylito
Copy link
Contributor Author

bobylito commented Dec 29, 2017

http://earthy-protest.surge.sh/ @Haroenv Maybe you will see something I don't.

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@bobylito bobylito merged commit b3185e5 into develop Dec 29, 2017
@bobylito bobylito deleted the fix/theme-pagination-height branch December 29, 2017 16:26
bobylito pushed a commit that referenced this pull request Jan 2, 2018
<a name=2.4.0></a>

* **pagination:** disable buttons if not results ([#2643](#2643)) ([9017b72](9017b72)), closes [#2014](#2014)
* **theme:** fix height of pagination ([#2641](#2641)) ([b3185e5](b3185e5))

* **core:** add a reload method on the InstantSearch component ([#2637](#2637)) ([e73ff13](e73ff13))
* **core:** add an error event to monitor error from Algolia ([#2642](#2642)) ([71c2d68](71c2d68)), closes [#1585](#1585)
* **core:** rename `reload` to `refresh` ([#2645](#2645)) ([9b8ac65](9b8ac65))
* **wrapWithHits:** enable async init ([#2635](#2635)) ([08a8747](08a8747))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants