fix(translation): allow undefined value to be passed on purpose

algolia · May 14, 2019 · ab81d0b · ab81d0b
1 parent fba5cdf
commit ab81d0b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/packages/react-instantsearch-core/src/core/__tests__/translatable.js b/packages/react-instantsearch-core/src/core/__tests__/translatable.js
@@ -25,15 +25,18 @@ describe('translatable', () => {
     const defaultTranslations = {
       sup: 'hey',
       thing: n => `${n} things`,
+      fallbackThing: 'hi',
     };
     const translations = {
       sup: 'hoy',
+      fallbackThing: undefined,
     };
     const Translated = translatable(defaultTranslations)(Dummy);
     const { translate } = shallow(<Translated translations={translations} />)
       .find(Dummy)
       .props();
     expect(translate('sup')).toBe('hoy');
     expect(translate('thing', 20)).toBe('20 things');
+    expect(translate('fallbackThing')).toBe(undefined);
   });
 });
diff --git a/packages/react-instantsearch-core/src/core/translatable.js b/packages/react-instantsearch-core/src/core/translatable.js
@@ -22,7 +22,7 @@ export default function translatable(defaultTranslations) {
         const { translations } = this.props;
 
         const translation =
-          translations && translations[key] !== undefined
+          translations && translations.hasOwnProperty(key)
             ? translations[key]
             : defaultTranslations[key];