feedback from review

algolia · Apr 12, 2019 · d5df439 · d5df439
1 parent 97abdcb
commit d5df439
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/packages/react-instantsearch-core/src/connectors/__tests__/connectConfigure.js b/packages/react-instantsearch-core/src/connectors/__tests__/connectConfigure.js
@@ -5,7 +5,7 @@ jest.mock('../../core/createConnector', () => x => x);
 
 describe('connectConfigure', () => {
   describe('single index', () => {
-    const contextValue = { ais: { mainTargetedIndex: 'index' } };
+    const contextValue = { mainTargetedIndex: 'index' };
 
     it('propagates the props to the SearchParameters without children & contextValue', () => {
       const searchParameters = connect.getSearchParameters.call(
@@ -45,9 +45,9 @@ describe('connectConfigure', () => {
     });
 
     it('calling transitionState should add configure parameters to the search state', () => {
-      const ctx = {};
+      const instance = {};
       let searchState = connect.transitionState.call(
-        ctx,
+        instance,
         {
           distinct: 1,
           whatever: 'please',
@@ -62,7 +62,7 @@ describe('connectConfigure', () => {
       });
 
       searchState = connect.transitionState.call(
-        ctx,
+        instance,
         { whatever: 'other', children: 'whatever', contextValue },
         { configure: { distinct: 1, whatever: 'please' } },
         { configure: { distinct: 1, whatever: 'please' } }

diff --git a/packages/react-instantsearch-core/src/connectors/__tests__/connectPagination.js b/packages/react-instantsearch-core/src/connectors/__tests__/connectPagination.js
@@ -62,7 +62,11 @@ describe('connectPagination', () => {
     });
 
     it("calling refine updates the widget's search state", () => {
-      const nextState = connect.refine({}, { otherKey: 'val' }, 'yep');
+      const nextState = connect.refine(
+        { contextValue },
+        { otherKey: 'val' },
+        'yep'
+      );
       expect(nextState).toEqual({
         otherKey: 'val',
         page: 'yep',