Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

refactor(lodash): pick #2432

Merged
merged 2 commits into from
May 13, 2019
Merged

refactor(lodash): pick #2432

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85e8b56
refactor(lodash): pick
Haroenv May 13, 2019
7e4800c
chore: remove isEmpty variable
Haroenv May 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 19 additions & 11 deletions packages/react-instantsearch-dom/src/components/HierarchicalMenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { pick } from 'lodash';
import React, { Component } from 'react';
import PropTypes from 'prop-types';
import { translatable } from 'react-instantsearch-core';
Expand Down Expand Up @@ -28,6 +27,7 @@ class HierarchicalMenu extends Component {
className: PropTypes.string,
limit: PropTypes.number,
showMoreLimit: PropTypes.number,
isEmpty: PropTypes.bool,
Haroenv marked this conversation as resolved.
Show resolved Hide resolved
transformItems: PropTypes.func,
};

Expand All @@ -51,20 +51,28 @@ class HierarchicalMenu extends Component {
};

render() {
const {
translate,
items,
showMore,
limit,
showMoreLimit,
isEmpty,
canRefine,
className,
} = this.props;
return (
<List
renderItem={this.renderItem}
cx={cx}
{...pick(this.props, [
'translate',
'items',
'showMore',
'limit',
'showMoreLimit',
'isEmpty',
'canRefine',
'className',
])}
translate={translate}
items={items}
showMore={showMore}
limit={limit}
showMoreLimit={showMoreLimit}
isEmpty={isEmpty}
canRefine={canRefine}
className={className}
/>
);
}
Expand Down
35 changes: 22 additions & 13 deletions packages/react-instantsearch-dom/src/components/Menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { pick } from 'lodash';
import React, { Component } from 'react';
import PropTypes from 'prop-types';
import { translatable } from 'react-instantsearch-core';
Expand Down Expand Up @@ -62,23 +61,33 @@ class Menu extends Component {
};

render() {
const {
translate,
items,
showMore,
limit,
showMoreLimit,
isFromSearch,
searchForItems,
searchable,
canRefine,
className,
} = this.props;
return (
<List
renderItem={this.renderItem}
selectItem={this.selectItem}
cx={cx}
{...pick(this.props, [
'translate',
'items',
'showMore',
'limit',
'showMoreLimit',
'isFromSearch',
'searchForItems',
'searchable',
'canRefine',
'className',
])}
translate={translate}
items={items}
showMore={showMore}
limit={limit}
showMoreLimit={showMoreLimit}
isFromSearch={isFromSearch}
searchForItems={searchForItems}
searchable={searchable}
canRefine={canRefine}
className={className}
/>
);
}
Expand Down
35 changes: 22 additions & 13 deletions packages/react-instantsearch-dom/src/components/RefinementList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { pick } from 'lodash';
import React, { Component } from 'react';
import PropTypes from 'prop-types';
import { translatable } from 'react-instantsearch-core';
Expand Down Expand Up @@ -67,23 +66,33 @@ class RefinementList extends Component {
};

render() {
const {
translate,
items,
showMore,
limit,
showMoreLimit,
isFromSearch,
searchForItems,
searchable,
canRefine,
className,
} = this.props;
return (
<List
renderItem={this.renderItem}
selectItem={this.selectItem}
cx={cx}
{...pick(this.props, [
'translate',
'items',
'showMore',
'limit',
'showMoreLimit',
'isFromSearch',
'searchForItems',
'searchable',
'canRefine',
'className',
])}
translate={translate}
items={items}
showMore={showMore}
limit={limit}
showMoreLimit={showMoreLimit}
isFromSearch={isFromSearch}
searchForItems={searchForItems}
searchable={searchable}
canRefine={canRefine}
className={className}
query={this.state.query}
/>
);
Expand Down