Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: don't use then/catch in command #57

Merged
merged 1 commit into from
Dec 6, 2023
Merged

lib: don't use then/catch in command #57

merged 1 commit into from
Dec 6, 2023

Conversation

JacksonTian
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (f7636db) 53.30% compared to head (9234ce9) 54.30%.

Files Patch % Lines
commands/login.js 0.00% 2 Missing ⚠️
lib/command.js 0.00% 2 Missing ⚠️
commands/pack.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   53.30%   54.30%   +1.00%     
==========================================
  Files          25       25              
  Lines        1696     1672      -24     
==========================================
+ Hits          904      908       +4     
+ Misses        792      764      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JacksonTian JacksonTian merged commit 706846b into master Dec 6, 2023
6 checks passed
@JacksonTian JacksonTian deleted the catch branch December 11, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants