Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dist/index.d.ts to package.json #104

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

kirill-konshin
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Mar 6, 2020

CLA assistant check
All committers have signed the CLA.

@eroshenkoam eroshenkoam added the type:improvement Improvement or request label Mar 6, 2020
@eroshenkoam eroshenkoam changed the title Fix #103 Add dist/index.d.ts to package.json Mar 6, 2020
@eroshenkoam eroshenkoam merged commit da11e44 into allure-framework:master Mar 6, 2020
@just-boris
Copy link
Contributor

just-boris commented Mar 7, 2020

Why is this needed? I am using 2.0.0-beta.6 with typescript and it resolves types just fine, without this change.

Moreover, this change points to a non-existing file ./dist/types.d.ts which breaks typescript. You even had to work around this:

// @ts-ignore
import MochaAllureReporter from "../..";

Can you give more context on what you were trying to do? I can try to help.

@kirill-konshin
Copy link
Contributor Author

Whoa, you’re right, I overlooked this typo, too much stuff was happening yesterday.

The reason for change is that if allure is used indirectly, through some intermediate lib, types can’t be traced by IDE without explicit types entry in package.json.

I will fix the mistake right now.

kirill-konshin added a commit to kirill-konshin/allure-js that referenced this pull request Mar 7, 2020
kirill-konshin added a commit to kirill-konshin/allure-js that referenced this pull request Mar 7, 2020
@kirill-konshin
Copy link
Contributor Author

#109 done

sseliverstov pushed a commit that referenced this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:improvement Improvement or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants