Refactor: add swappable writer to have in-memory results in testing #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-boris
commented
Aug 22, 2019
| const mocha = new Mocha(); | ||
| mocha.reporter(MochaAllureReporter, { writer }); |
There was a problem hiding this comment.
Here are the changes in a nutshell. Now it is possible to provide a custom writer implementation via options and redirect all output somewhere else.
sseliverstov
approved these changes
Aug 22, 2019
baev
approved these changes
Aug 22, 2019
There was a problem hiding this comment.
can we generate allure report for tests? In jenkinsfile you need to add
post {
always {
allure results: [[path: '**/build/allure-results']]
deleteDir()
}
}
see https://github.com/allure-framework/allure-java/blob/master/Jenkinsfile as the reference
|
@baev what report? Since we are writing everything to memory, there are no files to generate a report If you asked about running unit tests with the reporter enabled here, it would require more work about adding and configuring mocha-multi. Too much for the current PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is a preparation to fix #37 and #38. Per discussion with @baev we need to update testing infra first. This PR does that
Summary
Updated
tsconfig.json, remove the odd part about type roots, see individual commit for more details: 1dc4ac3Extracted
AllureWriterinterface fromAllureRuntime, create two implementations, default and in-memoryUpdated all adapters to support the new writer option
Replaced
GlobalInfoWriterwith new methods to support swappable writersChecklist