Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve original attachment file extension #956

Merged
merged 2 commits into from
May 21, 2024

Conversation

baev
Copy link
Member

@baev baev commented May 21, 2024

Context

Use extname from original file path in case of Writer#writeAttachmentFromPath method is used and no fileExtension option is specified.

Checklist

@github-actions github-actions bot added the theme:api Javascript API related issue label May 21, 2024
@baev baev added the type:improvement Improvement or request label May 21, 2024
@baev baev force-pushed the preserve-original-file-extension branch from 04e8910 to ff5c79f Compare May 21, 2024 11:58
@baev baev merged commit 5c83808 into main May 21, 2024
8 checks passed
@baev baev deleted the preserve-original-file-extension branch May 21, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:api Javascript API related issue type:improvement Improvement or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants