Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing 'escape' on fullscreen attach closes opened test, not attach #546

Closed
2 of 3 tasks
dimkin-eu opened this issue Aug 10, 2017 · 0 comments
Closed
2 of 3 tasks

Pressing 'escape' on fullscreen attach closes opened test, not attach #546

dimkin-eu opened this issue Aug 10, 2017 · 0 comments
Labels
type:bug Something isn't working

Comments

@dimkin-eu
Copy link

dimkin-eu commented Aug 10, 2017 •
edited
Loading

I'm submitting a ...

  • bug report
  • feature request
  • support request

What is the current behavior?

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

  1. open any test
  2. open any attach in fullscreen
  3. press escape
    ->
  4. fullscreen attach remains opened, but selected test in background closes

What is the expected behavior?

opened in fullscreen attach closes

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Allure version 2.3.1
Test framework testng@6.8
Allure adaptor allure-testng@2.0-BETA16
Generate report using allure-maven@2.18

Other information

image
@dimkin-eu dimkin-eu changed the title Pressing escape on fullscreen attach closes openet test, not attach Pressing 'escape' on fullscreen attach closes openet test, not attach Aug 10, 2017
@baev baev added the type:bug Something isn't working label Aug 10, 2017
@dimkin-eu dimkin-eu changed the title Pressing 'escape' on fullscreen attach closes openet test, not attach Pressing 'escape' on fullscreen attach closes opened test, not attach Aug 11, 2017
TpSr52 pushed a commit to TpSr52/allure2 that referenced this issue Oct 20, 2017
I have fixed pressing 'escape' on fullscreen attach closes opened tes…
ae0625e 
…t, not attach allure-framework#546
@TpSr52 TpSr52 mentioned this issue Oct 20, 2017
Merged
2 tasks
@baev baev closed this as completed in af5d544 Nov 14, 2017
@baev baev removed the work:backlog label Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@baev @dimkin-eu