Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump opencsv from 4.6 to 5.9 #2547

Merged
merged 2 commits into from
May 8, 2024
Merged

Conversation

kusaeva
Copy link
Contributor

@kusaeva kusaeva commented May 8, 2024

Context

Migrating to opencsv 5 using this information:
https://sourceforge.net/p/opencsv/support-requests/82/

Checklist

@CLAassistant
Copy link

CLAassistant commented May 8, 2024

CLA assistant check
All committers have signed the CLA.

@kusaeva kusaeva mentioned this pull request May 8, 2024
2 tasks
Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

@baev baev added the type:dependencies Pull requests that update a dependency label May 8, 2024
@baev
Copy link
Member

baev commented May 8, 2024

The functional change is that the header names are now in uppercase. According to com.opencsv.bean.HeaderColumnNameMappingStrategy#registerBinding, there is no way to modify the behaviour.

@baev
Copy link
Member

baev commented May 8, 2024

header names are now in uppercase

Personally, I'm ok with it. The code will not be reused in Allure 3 since it is written in pure TypeScript. The CSV module has already been implemented for Allure 3 in a much more customizable way.

If someone needs the old behaviour (with lowercase column names) — please feel free to create a discussion.

@baev
Copy link
Member

baev commented May 8, 2024

@kusaeva thanks!

@baev baev merged commit 3fc7bc2 into allure-framework:main May 8, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:build theme:plugin api type:dependencies Pull requests that update a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants