Expose "start" and "stop" timestamps as metrics #2626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavels Fjodorovs <pavels.fjodorovs@hotelplan.com>
baev
approved these changes
Jul 3, 2024
baev
added
the
type:improvement
|
@pfyod thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In order to be able to track whether tests actually ran, there should be some sort of timestamp in Prometheus / influxdb metrics.
This PR exposes existing
startandstoptimestamps fromGroupTimeas metrics inside theTimeMetricclass. I guess they were simply overlooked as all other properties ofGroupTimeare already exposed.Three are no existing unit tests for the involved classes, so not sure where would one add them and what to test there.
This fixes an existing issue #889.
Checklist