Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support foe disabled gtests by flagging them as skipped #798

Merged
merged 2 commits into from
Jul 18, 2018

Conversation

twigs
Copy link
Contributor

@twigs twigs commented Jun 4, 2018

[//]: # (
. Thank you so much for sending us a pull request!
.
. Make sure you have a clear name for your pull request.
. The name should start with a capital letter and no dot is required in the end of the sentence.
. To link the request with isses use the following notation: (fixes #123, fixes #321)
.
. An example of good pull request names:
. - Add Russian translation (fixes #123)
. - Add an ability to disable default plugins
. - Support emoji in test descriptions
)

Context

Without this fix disabled gtest test are listed as successful test executions instead of skipped tests.
This is due to the fact that gtests indicates disabled tests by setting status to notrun instead of using a skipped element in the junit output.
[//]: # (
Describe the problem or feature in addition to a link to the issues
)

Checklist

@baev baev merged commit f6efe2d into allure-framework:master Jul 18, 2018
@baev
Copy link
Member

baev commented Jul 18, 2018

@twigs thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support tab separated attachments
2 participants