Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default google test arguments for execution with ctest / make test #560

Conversation

BenjaminW3
Copy link
Member

Add some enhanced default command line options to the tests executed via ctest or make test to enhance the output. Currently they are manually given as command line arguments to the executables in CI.

Copy link
Member

@sbastrakov sbastrakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really a newbie cmake user, so a question may be naive, but still. Is there no reasonable way to avoid duplication e.g. define a function which takes a test name and does the ADD_TEST stuff with proper default arguments? Or speaking even more widely, these CMakeLists.txt for tests are essentially the same.

Also, although it's not the topic of this PR, should the years in the headers of cmake files be updated? Are still 2017.

@BenjaminW3
Copy link
Member Author

Yes, we could add such a function. It is not that easy because the tests are currently completely independant. I would add such a thing once #543 is resolved, which I am currently working on.

@BenjaminW3
Copy link
Member Author

We could update the year but I do not see it as necessary. We may think about applying a script to the whole repo which updates the year for all files.

@BenjaminW3 BenjaminW3 merged commit 588a220 into alpaka-group:develop Jul 4, 2018
@BenjaminW3 BenjaminW3 deleted the topic-ctest-googletest-default-args branch July 4, 2018 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants