Improve viewcopy benchmark #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bernhardmgruber
commented
Feb 2, 2024
•
bernhardmgruber
commented
- Simplify copy implementation
- Add a fastpath copy for aligned AoSoA
- Skip single blob SoA in viewcopy
- Consistenly use mp_for_each_inline inside LLAMA
- Make mpForEachInline public and more like Mp11 version
- Parallelize init and hash in viewcopy
bernhardmgruber
force-pushed
the
viewcopy_base
branch
from
00078a8
to
c553b92
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #842 +/- ##
===========================================
- Coverage 98.73% 98.73% -0.01%
===========================================
Files 70 70
Lines 6902 6897 -5
===========================================
- Hits 6815 6810 -5
Misses 87 87 |
bernhardmgruber
force-pushed
the
viewcopy_base
branch
from
c553b92
to
fa9771c
Compare
* Rename the function to mp_for_each_inline * Take list as template parameter only
* Hardcode readOpt heuristic * Drop readOpt parameter from aosoaCommonBlockCopy interface * Remove aosoaCommonBlockCopy runs from viewcopy
bernhardmgruber
force-pushed
the
viewcopy_base
branch
from
fa9771c
to
fe83bdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.