Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow DynamoQuery usage with no DataTable #31

Merged
merged 3 commits into from
May 29, 2020
Merged

Conversation

vemel
Copy link
Contributor

@vemel vemel commented May 28, 2020

Notes

The idea is to use DataTable explicitly only on DynamoTable level, but not on DyanmoQuery

Public API changes

Added

  • DataTable.copy method

Changed

  • DataTable.keys returns an iterator (not compatible with a regular dict)
  • DataTable.values returns an iterator (not compatible with a regular dict)
  • DataTable.items returns an iterator (not compatible with a regular dict)
  • DataTable.__iter__ iterates over records (used to be keys) and fails for non-normalized tables
  • DynamoQuery.execute_dict method's data argument made optional
  • DynamoQuery.execute method's data_table argument accepts Iterable[Dict] a well as a DataTable

Fixed

  • Typing for subclassed DataTable

@github-actions github-actions bot added the minor label May 28, 2020
@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #31 into master will decrease coverage by 0.02%.
The diff coverage is 97.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   95.34%   95.31%   -0.03%     
==========================================
  Files          13       13              
  Lines        1567     1581      +14     
==========================================
+ Hits         1494     1507      +13     
- Misses         73       74       +1     
Impacted Files Coverage Δ
dynamo_query/data_table.py 99.44% <96.55%> (-0.56%) ⬇️
dynamo_query/base_dynamo_query.py 100.00% <100.00%> (ø)
dynamo_query/dynamo_query_main.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e3a503...d35ebd6. Read the comment docs.

@vemel vemel merged commit 1314281 into master May 29, 2020
@github-actions github-actions bot mentioned this pull request May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant