Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caching for DynamoTable #48

Merged
merged 6 commits into from
Jul 8, 2020
Merged

Caching for DynamoTable #48

merged 6 commits into from
Jul 8, 2020

Conversation

vemel
Copy link
Contributor

@vemel vemel commented Jul 8, 2020

Public API changes

Added

  • DynamoTable.cached_batch_get method
  • DynamoTable.cached_get_record method
  • DynamoTable.invalidate_cache method

Fixed

  • DynamoTable does not use sort key if it does not exist in record
  • Always use provided DynamoQuery subclass in DynamoTable
  • Filter out non-key data from batch methods

@github-actions github-actions bot added the minor label Jul 8, 2020
@vemel vemel changed the title Fix usage of derived DynamoQuery Caching for DynamoTable Jul 8, 2020
amirkav
amirkav previously approved these changes Jul 8, 2020
View reviewed changes
@vemel vemel merged commit 9e6d058 into master Jul 8, 2020
@github-actions github-actions bot mentioned this pull request Jul 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amirkav amirkav amirkav approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vemel @amirkav