Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding fbprophet to requirements #198

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Conversation

iercan
Copy link
Contributor

@iercan iercan commented Dec 1, 2020

facebook probhet enables new timeseries chart vis type. See apache/superset#10324

@amancevice amancevice merged commit 98932aa into amancevice:main Dec 1, 2020
@amancevice
Copy link
Owner

the installation instructions for fbprophet indicate that pystan needs to be installed as well. I don't know anything about either library and cannot test, but happy to add if it's simple enough.

@iercan
Copy link
Contributor Author

iercan commented Dec 1, 2020

@amancevice I just installed fbprophet and it worked.

@iercan
Copy link
Contributor Author

iercan commented Dec 1, 2020

I just checked. Looks like pystan also installed as dependency. So there is no problem

@amancevice
Copy link
Owner

sounds good. I'll cut a new tag—let me know if there are any problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants