Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Handle fetch support #145

Merged
merged 3 commits into from
Dec 16, 2018

Conversation

aniketnk
Copy link
Contributor

Added support for Github Handles.
It fetches avatar given a GitHub handle.
See example in demo/index.js for details of usage.

Added support for Github Handles.
Fetches avatar given GitHub handle.
@JorgenEvens
Copy link
Member

Hi @aniketnk,

Awesome addition, this is really great!
Could you add the githubHandle property to the README and typescript definitions?

@aniketnk
Copy link
Contributor Author

Hey,
I've added the githubHandle property and updated the typescript definitions. You can check it out!

@JorgenEvens JorgenEvens merged commit 8ec72f0 into ambassify:master Dec 16, 2018
@JorgenEvens
Copy link
Member

@aniketnk awesome, thanks!

@JorgenEvens JorgenEvens added this to the 3.5.0 milestone Dec 18, 2018
@JorgenEvens
Copy link
Member

This has been released as part of version v3.5.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants