Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Deferred::resolve types #307

Merged
merged 1 commit into from
Apr 5, 2020
Merged

Improve Deferred::resolve types #307

merged 1 commit into from
Apr 5, 2020

Conversation

enumag
Copy link
Contributor

@enumag enumag commented Apr 4, 2020

No description provided.

@enumag enumag closed this Apr 4, 2020
@kelunik
Copy link
Member

kelunik commented Apr 5, 2020

@enumag Why did you close this?

@enumag
Copy link
Contributor Author

enumag commented Apr 5, 2020

@kelunik Because it didn't fix the error I was experiencing anyway and only made it worse... Although I do know that it is technically correct to resolve with a Promise... Reopen and merge it if you wish.

@kelunik kelunik reopened this Apr 5, 2020
@kelunik kelunik changed the title Fix Deferred Improve Deferred::resolve types Apr 5, 2020
@kelunik kelunik merged commit 2053b42 into amphp:master Apr 5, 2020
@kelunik
Copy link
Member

kelunik commented Apr 5, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelunik kelunik kelunik approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enumag @kelunik