Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:Ignore Helm artifacts #1036

Merged
merged 1 commit into from
May 3, 2021

Conversation

benrifkind
Copy link
Contributor

Signed-off-by: benrifkind ben.rifkind@gmail.com

Summary of Changes

Adds to the .gitignore so that Helm artifacts are not tracked. This is to avoid dirtying the working directory after running helm update.

$> git status
Untracked files:
  (use "git add <file>..." to include in what will be committed)
	amundsen-kube-helm/templates/helm/charts/
	amundsen-kube-helm/templates/helm/requirements.lock

Documentation

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely, including a title prefix.
  • PR includes a summary of changes.
  • My commits follow the guidelines from "How to write a good git commit message"

Signed-off-by: benrifkind <ben.rifkind@gmail.com>
@benrifkind benrifkind requested a review from a team as a code owner May 3, 2021 22:29
@feng-tao feng-tao merged commit f6b21b3 into amundsen-io:main May 3, 2021
@benrifkind benrifkind deleted the gitignore-helm-packaging branch May 3, 2021 22:39
feng-tao pushed a commit that referenced this pull request May 7, 2021
Signed-off-by: benrifkind <ben.rifkind@gmail.com>
zacr pushed a commit to SaltIO/amundsen that referenced this pull request May 13, 2022
Signed-off-by: benrifkind <ben.rifkind@gmail.com>
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this pull request Jun 30, 2022
Signed-off-by: benrifkind <ben.rifkind@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants