Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate databuilder to neo4j-driver 4.4.5 #1938

Merged
merged 8 commits into from
Jul 21, 2022
Merged

chore: migrate databuilder to neo4j-driver 4.4.5 #1938

merged 8 commits into from
Jul 21, 2022

Conversation

allisonsuarez
Copy link
Contributor

@allisonsuarez allisonsuarez commented Jul 21, 2022 •
edited
Loading

NOT BW COMPATIBLE, UPGRADE NEO4J DB >= 3.5.5

The newest driver is compatible with neo4j DB version >= 3.5 which was released in 2018.

@allisonsuarez
chore: upgrade neo4j-driver to 4.4.5
815957f 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@boring-cyborg boring-cyborg bot added the area:databuilder From databuilder folder label Jul 21, 2022
@allisonsuarez
bumped driver version and removed neotime since it is no longer a dep…
bd64ded 
…endency

Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
create array fo results
0d9dbed 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
create aaraay fo results
23b7e13 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
staleness removal records array
c112104 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
make sure driver is correctly configured
262dd4f 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez
databuilder v7.0.0
c200aa5 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@allisonsuarez allisonsuarez marked this pull request as ready for review July 21, 2022 20:12
@allisonsuarez allisonsuarez mentioned this pull request Jul 21, 2022
Closed
@allisonsuarez allisonsuarez changed the title chore: migrate to neo4j-driver 4.4.5 chore: migrate databuilder to neo4j-driver 4.4.5 Jul 21, 2022
kristenarmes
kristenarmes approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@kristenarmes kristenarmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

feng-tao
feng-tao reviewed Jul 21, 2022
View reviewed changes
Copy link
Member

@feng-tao feng-tao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also change those version in docker file?

@allisonsuarez
Copy link
Contributor Author

could you also change those version in docker file?

wait which one? I just updated the neo4j python driver but the neo4j db version is fine since its >3.5

@allisonsuarez
bumped service versions for docker images
eb0cfd3 
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
@boring-cyborg boring-cyborg bot added the area:all Related to all the project label Jul 21, 2022
dkunitsk
dkunitsk approved these changes Jul 21, 2022
View reviewed changes
Copy link

@dkunitsk dkunitsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@allisonsuarez allisonsuarez merged commit 5d83413 into main Jul 21, 2022
@kristenarmes kristenarmes mentioned this pull request Aug 12, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feng-tao feng-tao feng-tao left review comments

@dkunitsk dkunitsk dkunitsk approved these changes

@kristenarmes kristenarmes kristenarmes approved these changes

@jinhyukchang jinhyukchang Awaiting requested review from jinhyukchang jinhyukchang is a code owner

@dorianj dorianj Awaiting requested review from dorianj

@verdan verdan Awaiting requested review from verdan verdan is a code owner

@mgorsk1 mgorsk1 Awaiting requested review from mgorsk1 mgorsk1 is a code owner

@youngyjd youngyjd Awaiting requested review from youngyjd youngyjd is a code owner

@dechoma dechoma Awaiting requested review from dechoma dechoma is a code owner

@sewardgw sewardgw Awaiting requested review from sewardgw sewardgw is a code owner

Assignees
No one assigned
Labels
area:all Related to all the project area:databuilder From databuilder folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@allisonsuarez @feng-tao @dkunitsk @kristenarmes