Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Exclude stats icon if configured stat types are the only ones present #1939

Conversation

kristenarmes
Copy link
Contributor

Signed-off-by: Kristen Armes karmes@lyft.com

Summary of Changes

This change adds a config to allow adding a list of stat types where, if they are the only ones present for a column, the stats icon will not be displayed next to that column's name. This is useful in the case of columns only having very common stats, such as column usage, so the users will not click on the column expecting to see more info. The default value is an empty list so this will only affect those who configure it.

Tests

Added a test for the config, and modified tests for determining whether the icon is displayed for a given column

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Signed-off-by: Kristen Armes <karmes@lyft.com>
Copy link
Contributor

@allisonsuarez allisonsuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just comment on config naming

Signed-off-by: Kristen Armes <karmes@lyft.com>
@kristenarmes kristenarmes merged commit 7a0366f into amundsen-io:main Jul 22, 2022
@kristenarmes kristenarmes deleted the add-configurable-stat-types-to-exclude-icon-display branch July 22, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend From the Frontend folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants