Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: For new publisher fix error handling for already created constraints/indices #1963

Merged

Conversation

kristenarmes
Copy link
Contributor

@kristenarmes kristenarmes commented Aug 17, 2022

Signed-off-by: Kristen Armes karmes@lyft.com

Summary of Changes

It appears the new neo4j driver uses a different error message than it did before for indicating that constraints or indices have already been created. This change updates the publisher check to look for the error status code instead of a line of text.

Tests

N/A

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Signed-off-by: Kristen Armes <karmes@lyft.com>
Signed-off-by: Kristen Armes <karmes@lyft.com>
@boring-cyborg boring-cyborg bot added the area:databuilder From databuilder folder label Aug 17, 2022
@kristenarmes kristenarmes marked this pull request as ready for review August 17, 2022 18:13
@kristenarmes kristenarmes merged commit e9e07f0 into amundsen-io:main Aug 17, 2022
@kristenarmes kristenarmes deleted the fix-constraint-exception-message branch August 17, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:databuilder From databuilder folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants