Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Make sqlalchemy_extractor compatible with sqlalchemy>=1.4 #2213

Conversation

mikekutzma
Copy link
Contributor

feat: Make sqlalchemy_extractor compatible with sqlalchemy>=1.4
(Moved from #2209)

Description

These changes to the sql_alchemy_extractor module allow for using the extractors with updated versions of sqlalchemy.

Motivation and Context

This addresses issues such as

How Has This Been Tested?

Tested using sampple_mssql_metadata.py script for

  • SQLAlchemy==1.3.16
  • SQLAlchemy==2.0.23

Documentation

None

CheckList

  • PR title addresses the issue accurately and concisely
  • Updates Documentation and Docstrings
  • Adds tests
  • Adds instrumentation (logs, or UI events)

Signed-off-by: mikekutzma <michaelkutzma@gmail.com>
@mikekutzma mikekutzma requested a review from a team as a code owner November 16, 2023 12:49
@boring-cyborg boring-cyborg bot added the area:databuilder From databuilder folder label Nov 16, 2023
Copy link
Contributor

@ozandogrultan ozandogrultan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please bump up the databuilder version as well?

Signed-off-by: Mike Kutzma <michaelkutzma@gmail.com>
@mikekutzma
Copy link
Contributor Author

@ozandogrultan Anything else needed for this one? Happy to update if needed

@mikekutzma
Copy link
Contributor Author

Bumping for review

Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Golodhros Golodhros enabled auto-merge (squash) December 6, 2023 09:23
@Golodhros Golodhros merged commit 613f78a into amundsen-io:main Dec 7, 2023
8 checks passed
Copy link

boring-cyborg bot commented Dec 7, 2023

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:databuilder From databuilder folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants