amend typos in get_dashboard_tables #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md) |
|
@sihaotan4 please check the details on the DCO task before we can review |
Signed-off-by: sihaotan4 <34644190+sihaotan4@users.noreply.github.com>
sihaotan4
force-pushed
the
fix_table_typos
branch
from
7c72374
to
44c87ef
Compare
|
@sihaotan4 can you bump the metadata version here to 3.12.3 so we can do a new release? then we can approve the changes, thanks! |
Signed-off-by: sihaotan4 <34644190+sihaotan4@users.noreply.github.com>
sihaotan4
requested review from
feng-tao,
jinhyukchang,
allisonsuarez,
verdan,
bolkedebruin,
mgorsk1,
youngyjd,
dechoma,
sewardgw,
dkunitsk,
kristenarmes,
ozandogrultan and
B-T-D
as code owners
kristenarmes
approved these changes
Dec 19, 2023
|
Awesome work, congrats on your first merged pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Corrected 3 typos in
_get_dashboard_tableswhere "table" was misspelled.How Has This Been Tested?
Tested internally on Neptune server. This change does not affect function logic and the function's return value in any way.
Documentation
No documentation added.
CheckList