Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove py37 support, and unify compatibility matrix from 3.8-3.9 #2226

Merged
merged 7 commits into from
Feb 22, 2024

Conversation

kristenarmes
Copy link
Contributor

@kristenarmes kristenarmes commented Jan 5, 2024

Description

Remove python 3.7 support since it has reached its EOL, and unify the compatibility matrix across services to include 3.8 and 3.9

Motivation and Context

We are going to be upgrading our services to py3.10 soon, so this is getting the project set up for that. py3.10 won't be added in this PR yet because it appears to require other package upgrades, so keeping the focus on removing py3.7 here. We will need to upgrade flask and werkzeug with our py3.10 upgrade, and werkzeug 3.0.1 does not support py3.7 so that is the main motivation.

How Has This Been Tested?

Documentation

Updated all relevant docs that show version requirements

CheckList

  • PR title addresses the issue accurately and concisely
  • Updates Documentation and Docstrings
  • Adds tests
  • Adds instrumentation (logs, or UI events)

Signed-off-by: Kristen Armes <karmes@lyft.com>
@boring-cyborg boring-cyborg bot added area:common From common folder area:databuilder From databuilder folder area:dev-tools area:docs area:frontend From the Frontend folder area:metadata From the metadata folder area:search From the search folder labels Jan 5, 2024
Signed-off-by: Kristen Armes <karmes@lyft.com>
@kristenarmes kristenarmes changed the title chore: Remove py37 support, and unify compatibility matrix from 3.8-3.10 chore: Remove py37 support, and unify compatibility matrix from 3.8-3.9 Jan 5, 2024
Signed-off-by: Kristen Armes <karmes@lyft.com>
Signed-off-by: Kristen Armes <karmes@lyft.com>
Signed-off-by: Kristen Armes <karmes@lyft.com>
Signed-off-by: Kristen Armes <karmes@lyft.com>
Signed-off-by: Kristen Armes <karmes@lyft.com>
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kristenarmes kristenarmes merged commit 890bfaf into main Feb 22, 2024
17 checks passed
@kristenarmes kristenarmes deleted the karmes-remove-py37 branch February 22, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:common From common folder area:databuilder From databuilder folder area:dev-tools area:docs area:frontend From the Frontend folder area:metadata From the metadata folder area:search From the search folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants