Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade flask to 2.2.5 and its related dependencies #2237

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

kristenarmes
Copy link
Contributor

@kristenarmes kristenarmes commented Mar 1, 2024

Description

  • Upgrading flask version to 2.2.5, along with some related dependencies.
  • With the later version of werkzeug, I had to update tests that used API calls to pass json instead of data (or instead of nothing) as a param to indicate the expected content type. See release notes from version 2.3.0.

Motivation and Context

We need to upgrade flask due to py3.10 version requirements. This change will also resolve some security dependencies in the project.

How Has This Been Tested?

Ran our frontend, metadata, and search services locally to ensure there were no issues.

Documentation

N/A

CheckList

  • PR title addresses the issue accurately and concisely
  • Updates Documentation and Docstrings
  • Adds tests
  • Adds instrumentation (logs, or UI events)

Signed-off-by: Kristen Armes <karmes@lyft.com>
@boring-cyborg boring-cyborg bot added area:common From common folder area:databuilder From databuilder folder area:frontend From the Frontend folder area:metadata From the metadata folder area:search From the search folder labels Mar 1, 2024
Signed-off-by: Kristen Armes <karmes@lyft.com>
Signed-off-by: Kristen Armes <karmes@lyft.com>
Signed-off-by: Kristen Armes <karmes@lyft.com>
Copy link
Contributor

@B-T-D B-T-D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kristenarmes kristenarmes merged commit 125b04f into main Mar 6, 2024
17 checks passed
@kristenarmes kristenarmes deleted the karmes-upgrade-flask-and-deps branch March 6, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:common From common folder area:databuilder From databuilder folder area:frontend From the Frontend folder area:metadata From the metadata folder area:search From the search folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants