chore: Add py3.10 to compatibility matrix across all services except for metadata #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:common
feng-tao
approved these changes
Apr 4, 2024
Signed-off-by: Kristen Armes <karmes@lyft.com>
kristenarmes
force-pushed
the
karmes-py310-compatibility
branch
from
5b3bafb
to
765ed78
Compare
|
Looks good! Please fix broken tests before merging in |
Signed-off-by: Kristen Armes <karmes@lyft.com>
Signed-off-by: Kristen Armes <karmes@lyft.com>
…ted tests Signed-off-by: Kristen Armes <karmes@lyft.com>
kristenarmes
changed the title
kristenarmes
requested review from
jinhyukchang,
allisonsuarez,
verdan,
bolkedebruin,
mgorsk1,
youngyjd,
dechoma,
sewardgw,
dkunitsk,
ozandogrultan,
B-T-D,
ttannis and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding py3.10 to compatibility matrix across all services except for metadata.
Metadata is blocked by amundsengremlin:
overridespackage needs to be upgraded, which is doablegremlinpythonpackage needs to be upgraded, but there are some extra changes required for this when you go >=3.5.0 since it stops using thetornadopackage, and there are some restrictions with Neptune (see some details here). Since I don't use Neptune and have a good way of testing this to make sure it works, I am going to leave metadata out for now.Motivation and Context
We are going to be upgrading our services to py3.10, so want to make sure everything will work as expected
How Has This Been Tested?
Tests will run on py3.10 as part of this PR
Documentation
CheckList