sidekiqz2: use Pluto's msd data #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a bit of internal discussion it was decided to go ahead with just symlinking the `msd` for Pluto into SidekiqZ2. If this changes later on, it can be re-adapted. Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Instead of adding the `board/sidekiqz2/VERSIONS` file to the list, we're just going to ignore all `board/*/VERSIONS` files. This should extend to any future (similar) board builds that may be added. Added Vim swap files to avoid accidental committing them. Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
mhennerich
approved these changes
May 18, 2018
mhennerich
approved these changes
May 18, 2018
This was removed in the initial version. Add it back. Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
|
Changelog v1 -> v2:
|
mhennerich
approved these changes
May 18, 2018
|
Will merge this later today if no objections. |
|
I think this may be problematic. The html file in the pluto directory says to call ADI for support. That shouldn't be the answer on the sidekick There needs to be something else on the Epiq side, that Epiq needs to write, and send a pull request for. However, when you submit a change, and then commit it before 8:00am Eastern, it's not enough time for anyone to react, or comment on things. What you had before was fine for Epiq to replace. |
|
ok will revert the patch |
|
thanks. |
f--t
pushed a commit
to f-tf/buildroot
that referenced
this pull request
Aug 27, 2018
…-symlink-pluto-msd sidekiqz2: use Pluto's msd data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a bit of internal discussion it was decided to go ahead with just symlinking the
msdfor Pluto into SidekiqZ2.If this changes later on, it can be re-adapted.
Signed-off-by: Alexandru Ardelean alexandru.ardelean@analog.com