-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove private Angular API usage #193
Comments
@IgorMinar - Can you provide some insight how Angular Universal addresses calls such as the previous
|
Refs #191 |
**flex-layout** uses private APIs from @angular/core. These apis are no longer available in A4. NOTE: `custom-matchers.ts` still uses the private API for Angular 2.x unit testing. Further work is need to identify a reasonable work-around for all versions of Angular. Fixes #193.
**flex-layout** uses private APIs from @angular/core. These apis are no longer available in A4. NOTE: `custom-matchers.ts` still uses the private API for Angular 2.x unit testing. Further work is need to identify a reasonable work-around for all versions of Angular. Fixes #193.
**flex-layout** uses private APIs from @angular/core. These apis are no longer available in A4. NOTE: `custom-matchers.ts` still uses the private API for Angular 2.x unit testing. Further work is need to identify a reasonable work-around for all versions of Angular. Fixes #193.
@vikerman can help with the universal support question. |
**flex-layout** uses private APIs from @angular/core. These apis are no longer available in A4. NOTE: `custom-matchers.ts` still uses the private API for Angular 2.x unit testing. Further work is need to identify a reasonable work-around for all versions of Angular. Fixes angular#193.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
When testing Angular 4 in google3 we discovered that flex-layout uses private APIs from
@angular/core
. These apis are no longer available in A4. Please remove the usage:flex-layout/src/lib/flexbox/api/base.ts
Lines 10 to 11 in f9f16f5
flex-layout/src/lib/flexbox/api/base.ts
Line 95 in f9f16f5
in google3 we made the following local modification:
before:
after:
please note that the global
window
object hasgetComputedStyle
whichgetDOM
delegated the call, so this modification is equivalent to the original both at design time and at run time.The text was updated successfully, but these errors were encountered: