feat(api): add responsive API for img elements #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasBurleson
force-pushed
the
thomas/fix-img-src
branch
from
91fc232
to
87bef21
Compare
ThomasBurleson
changed the title
ThomasBurleson
force-pushed
the
thomas/fix-img-src
branch
2 times, most recently
from
6d82622
to
3c00609
Compare
ThomasBurleson
changed the title
* add responsive API to img[src.md], img[src.lt-lg], img[src.gt-xs], etc.
* skip actions if responsive keys are not defined
* without responsive keys (`src.<alias>`) defined, the ImgSrcDirective should **fall-through** and not change any attributes or properties on the `img` DOM element. The `img.src` attribute is dynamically set only when responsive keys are defined.
* defaults to `src=""` if not explicitly assigned
* responsive key activation will then assign the activated value to `img.src` attribute.
Closes #366, Fixes #81, Fixes #376.
ThomasBurleson
force-pushed
the
thomas/fix-img-src
branch
from
3c00609
to
7390242
Compare
|
@jelbourn - previous issues where |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src.<alias>) defined, the ImgSrcDirective should fall-through and not change any attributes or properties on theimgDOM element. Theimg.srcattribute is dynamically set only when responsive keys are defined.src=""if not explicitly assignedimg.srcattribute.Closes #366, Fixes #81, Fixes #376.