Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

select: icon is wrongly positioned in IE11 #10714

Closed
johnjesse opened this issue Jun 2, 2017 · 3 comments · Fixed by #11544
Closed

select: icon is wrongly positioned in IE11 #10714

johnjesse opened this issue Jun 2, 2017 · 3 comments · Fixed by #11544
Assignees
Labels
browser: IE This issue is specific to Internet Explorer has: Pull Request A PR has been created to address this issue P2: required Issues that must be fixed. resolution: fixed type: bug
Milestone

Comments

@johnjesse
Copy link

Actual Behavior:

it looks like this
image

it should look like this
image

CodePen (or steps to reproduce the issue): *

  • CodePen Demo which shows your issue:
  • Details:

See above, open the page in internet explorer

AngularJS Versions: *

  • AngularJS Version:
  • AngularJS Material Version:

Additional Information:

  • Browser Type: *
  • Browser Version: *
  • OS: *
  • Stack Traces:

Browser: Internet Explorer, Version: 11.0.9600.18665CO

The actual problem is you are using text-align: end to define the position of the icon, Internet Explorer has no support for using end with text-align (note Edge also has questionable support according to MDN https://developer.mozilla.org/en-US/docs/Web/CSS/text-align?v=example)

Solution
Use text-align: right in ltr environments and text-align: left in rtl environments


Shortcut to create a new CodePen Demo.
Note: * indicates required information. Without this information, your issue may be auto-closed.

Do not modify the titles or questions. Simply add your responses to the ends of the questions.
Add more lines if needed.

@johnjesse
Copy link
Author

#3840 It seems to have been raised before, although it is clearly not fixed

@Splaktar Splaktar changed the title md-select icon is wrongly positioned in IE select: icon is wrongly positioned in IE11 Dec 15, 2018
@Splaktar Splaktar added the browser: IE This issue is specific to Internet Explorer label Dec 15, 2018
@Splaktar Splaktar self-assigned this Dec 15, 2018
@Splaktar Splaktar added type: bug P2: required Issues that must be fixed. labels Dec 15, 2018
@Splaktar Splaktar added this to the 1.1.12 milestone Dec 15, 2018
@Splaktar
Copy link
Member

This was tweaked in 70c0c6e, but that only made the carrot not show up under the text. It didn't fix the left-to-right alignment.

I'll try out the changes from https://github.com/angular/material/pull/3840/files to see if they are still effective.

Splaktar added a commit that referenced this issue Dec 15, 2018
@Splaktar Splaktar added the has: Pull Request A PR has been created to address this issue label Dec 15, 2018
@Splaktar
Copy link
Member

PR #11544 posted to fix this.

@Splaktar Splaktar modified the milestones: 1.1.12, 1.1.13 Jan 3, 2019
mmalerba pushed a commit that referenced this issue Jan 7, 2019
<!-- 
Filling out this template is required! Do not delete it when submitting a Pull Request! Without this information, your Pull Request may be auto-closed.
-->
## PR Checklist
Please check that your PR fulfills the following requirements:
- [x] The commit message follows [our guidelines](https://github.com/angular/material/blob/master/.github/CONTRIBUTING.md#-commit-message-format)
- [ ] Tests for the changes have been added or this is not a bug fix / enhancement
- [x] Docs have been added, updated, or were not required

## PR Type
What kind of change does this PR introduce?
<!-- Please check the one that applies to this PR using "x". -->
```
[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:
```

## What is the current behavior?
Carrots in `md-select`s are not aligned to the end in IE11 as explained in the issue.
<!-- Please describe the current behavior that you are modifying and link to one or more relevant issues. -->
Issue Number: 
Fixes #10714. Relates to #3840.

## What is the new behavior?
Carrots are properly positioned in IE11, Edge, Chrome, and Firefox.

## Does this PR introduce a breaking change?
```
[ ] Yes
[x] No
```
<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->
<!-- Note that breaking changes are highly unlikely to get merged to master unless the validation is clear and the use case is critical. -->

## Other information
Thank you to @prestonvanloon for the original fix here in #3840.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
browser: IE This issue is specific to Internet Explorer has: Pull Request A PR has been created to address this issue P2: required Issues that must be fixed. resolution: fixed type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants