Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

colors and hues should be available everywhere. #1269

Closed
SanderElias opened this issue Jan 23, 2015 · 77 comments
Closed

colors and hues should be available everywhere. #1269

SanderElias opened this issue Jan 23, 2015 · 77 comments
Labels
for: internal contributor The team will address this issue and community PRs are not requested. resolution: fixed type: build type: enhancement type: feature
Milestone
1.1.0

Comments

@SanderElias
Copy link
Contributor

I created this sample on plunker to demonstrate a few issues I'm having with forms.

If you look at like 24 of index.html in my sample, you see there is a heading there. This heading is not visible in the page, because I don't know how to set the background color according to the current selected theme/colorpallete. I added an md-hue-1 to the class-list as well as an attribute, but it is not giving the result I need.

This is also mentioned in #537, but I still could not find a solution to it.
@SanderElias
Copy link
Contributor Author

I took my solution from #537. and rewrote it a bit so it will work with the new $mdThemingProvider.
For anybody that need something similar, have a look at my mdColors module. It's available in this plunker

This will serve my needs for now, but it still feels awkward that I have to go trough those lengths just to be able to get my hands on the selected color palette.
I still feel like I somehow miss the obvious!

@naomiblack naomiblack modified the milestone: 0.8.0 Jan 26, 2015
@iRouge
Copy link

iRouge commented Jan 27, 2015

Sander, I share your feelings, your concerns... and your solution !

Thanks a lot

@SanderElias
Copy link
Contributor Author

@iRouge I began to believe I was to only one ;)

@ThomasBurleson ThomasBurleson modified the milestones: 0.8.0, 0.7.1, 0.9.0 Jan 30, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 0.8.0, 0.9.0 Feb 17, 2015
@ThomasBurleson
Copy link
Contributor

@SanderElias - I think we should include a version of your colors.js and publish a service $mdColors service for easy color lookups.
@rschmukler - thoughts ?

@ThomasBurleson ThomasBurleson self-assigned this Feb 17, 2015
@SanderElias
Copy link
Contributor Author

@ThomasBurleson I would like that! Should I add support for md-hue-x and so on too?

@ThomasBurleson
Copy link
Contributor

@SanderElias - let's start with a simple, clean API for the initial work.
Can you create the $mdColors service and submit a PR ? Thx is advance.

@jonnysamps
Copy link

I believe I have a pretty solution for color lookups: checkout my plunkr: http://plnkr.co/edit/gBDV2ABghTMqqs5YaElB?p=preview

@SanderElias
Copy link
Contributor Author

@marcysutton I'm preparing an PR, as it looks now, I will be done by the end of the day.

SanderElias added a commit to SanderElias/material that referenced this issue Feb 19, 2015
@SanderElias
Create colors.js
1842bcb 
A service to create css rules for foreground and background colors a talked about in angular#1269
This was referenced Feb 19, 2015
Merged
Closed
@robertmesserle robertmesserle added this to the 0.9.0 milestone Feb 19, 2015
EladBezalel added a commit that referenced this issue Mar 29, 2016
@EladBezalel
feat(colors): directive to use any color from any palette everywhere
4b3274a 
- added directive

fixes #1269
@EladBezalel EladBezalel mentioned this issue Mar 29, 2016
Closed
EladBezalel added a commit that referenced this issue Mar 29, 2016
@EladBezalel
feat(colors): directive to use any color from any palette everywhere
c9ea280 
- added directive and documentation

fixes #1269
EladBezalel added a commit that referenced this issue Mar 30, 2016
@EladBezalel
feat(colors): directive to use any color from any palette everywhere
a6317e0 
- added directive and documentation
- added tests
- added smart watch option, when the directive recognize at least one of it's values needs interpolation it starts to watch it

fixes #1269
EladBezalel added a commit that referenced this issue Mar 30, 2016
@EladBezalel
feat(colors): directive to use any color from any palette everywhere
79a2490 
- added directive and documentation
- added tests
- added smart watch option, when the directive recognize at least one of it's values needs interpolation it starts to watch it

fixes #1269
EladBezalel added a commit that referenced this issue Mar 30, 2016
@EladBezalel
feat(colors): directive to use any color from any palette everywhere
dffb9e7 
- added directive and documentation
- added tests
- added smart watch option, when the directive recognize at least one of it's values needs interpolation it starts to watch it

fixes #1269
@wallzero
Copy link

wallzero commented Apr 2, 2016

+1

EladBezalel added a commit that referenced this issue Apr 3, 2016
@EladBezalel
feat(colors): directive and service to use any color from any palette…
ddeb37a 
… on any element

- directive and documentation
- service and documentation
- tests
- smart watch option, when the directive recognize at least one of it's values needs interpolation it starts to watch it
- mdColorsWatch - when set to false the directive doesn't watch for changes

fixes #1269
EladBezalel added a commit that referenced this issue Apr 3, 2016
@EladBezalel
feat(colors): directive and service to use any color from any palette…
a681c7c 
… on any element

- directive and documentation
- service and documentation
- tests
- smart watch option, when the directive recognize at least one of it's values needs interpolation it starts to watch it
- mdColorsWatch - when set to false the directive doesn't watch for changes

fixes #1269
@lukemiller
Copy link

+1

2 similar comments
@rguruprakash
Copy link

+1

@AElouai
Copy link

AElouai commented Apr 8, 2016

+1

EladBezalel added a commit that referenced this issue Apr 9, 2016
@EladBezalel
feat(colors): directive and service to use any color from any palette…
5526d74 
… on any element

- directive and documentation
- service and documentation
- tests
- smart watch option, when the directive recognize at least one of it's values needs interpolation it starts to watch it
- mdColorsWatch - when set to false the directive doesn't watch for changes

fixes #1269
EladBezalel added a commit that referenced this issue Apr 9, 2016
@EladBezalel
feat(colors): directive and service to use any color from any palette…
87b6704 
… on any element

- directive and documentation
- service and documentation
- tests
- smart watch option, when the directive recognize at least one of it's values needs interpolation it starts to watch it
- mdColorsWatch - when set to false the directive doesn't watch for changes

- $mdColorUtil - aggregate color related utils
- fixed theming scoping issue - THEME was defined globally which made it leak and changed for other modules

fixes #1269
ThomasBurleson pushed a commit that referenced this issue Apr 12, 2016
@EladBezalel @ThomasBurleson
feat(colors): directive and service to use any color from any palette…
54e6834 
… on any element

- directive and documentation
- service and documentation
- tests
- smart watch option, when the directive recognize at least one of it's values needs interpolation it starts to watch it
- mdColorsWatch - when set to false the directive doesn't watch for changes

- $mdColorUtil - aggregate color related utils
- fixed theming scoping issue - THEME was defined globally which made it leak and changed for other modules

fixes #1269

Closes #7791
EladBezalel added a commit that referenced this issue Apr 12, 2016
@EladBezalel
feat(colors): directive and service to use any color from any palette…
7350b5e 
… on any element

- directive and documentation
- service and documentation
- tests
- smart watch option, when the directive recognize at least one of it's values needs interpolation it starts to watch it
- mdColorsWatch - when set to false the directive doesn't watch for changes
- when using `background` property the directive will seamlessly set the foreground color according the palette hue

- $mdColorUtil - aggregate color related utils
- fixed theming scoping issue - THEME was defined globally which made it leak and changed for other modules

fixes #1269
EladBezalel added a commit that referenced this issue Apr 12, 2016
@EladBezalel
feat(colors): directive and service to use any color from any palette…
6aab69a 
… on any element

- directive and documentation
- service and documentation
- tests
- smart watch option, when the directive recognize at least one of it's values needs interpolation it starts to watch it
- mdColorsWatch - when set to false the directive doesn't watch for changes
- when using `background` property the directive will seamlessly set the foreground color according the palette hue

- $mdColorUtil - aggregate color related utils
- fixed theming scoping issue - THEME was defined globally which made it leak and changed for other modules

fixes #1269
@homerjam
Copy link

+1

@EladBezalel
Copy link
Member

@homerjam you can have this feature in 1.1.0-rc3

@homerjam
Copy link

Thanks - just had to refresh the docs! 😊

@lobo-tuerto
Copy link

The mdColors directive is listed in the documentation, but the $mdColors service isn't.

@EladBezalel
Copy link
Member

#8036 :)

@ghost
Copy link

ghost commented Jul 13, 2016

+1

@EladBezalel
Copy link
Member

EladBezalel commented Jul 13, 2016 •
edited
Loading

@Rahul-giri this is already in, check here

@Splaktar Splaktar modified the milestones: - Backlog, 1.1.0 Aug 17, 2018
@angular angular locked as resolved and limited conversation to collaborators Aug 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
for: internal contributor The team will address this issue and community PRs are not requested. resolution: fixed type: build type: enhancement type: feature
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

feat(colors): directive to use any color from any palette everywhere angular/material