Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-input-container should ignore hidden fields as part of the inputs its counting. #2153

Closed
heavysixer opened this issue Apr 3, 2015 · 0 comments
Assignees
Labels
pr: merge ready This PR is ready for a caretaker to review

Comments

@heavysixer
Copy link

I understand the purpose of having only a single visible input per container but this should not apply to hidden fields. Hidden fields are often used to track default parameters and therefore should be logically organized near the visible input. Consider the following example:

<md-input-container class="md-default-theme">
      <input name="account[remember_me]" type="hidden" value="0" class="md-input" id="input_001">
      <input type="checkbox" value="1" name="account[remember_me]" id="account_remember_me">
      <label for="account_remember_me">Remember me</label>
</md-input-container>
@marcysutton marcysutton added this to the 0.10.0 milestone Apr 17, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 0.10.0, 0.11.0 Jun 16, 2015
@ThomasBurleson ThomasBurleson modified the milestones: post-1.0 , 0.11.0 Jul 31, 2015
devversion added a commit to devversion/material that referenced this issue Dec 21, 2015
devversion added a commit to devversion/material that referenced this issue Dec 31, 2015
devversion added a commit to devversion/material that referenced this issue Jan 1, 2016
devversion added a commit to devversion/material that referenced this issue Jan 5, 2016
@ThomasBurleson ThomasBurleson modified the milestones: post-1.0 , Backlog Jan 5, 2016
devversion added a commit to devversion/material that referenced this issue Feb 4, 2016
devversion added a commit to devversion/material that referenced this issue Feb 4, 2016
BREAKING CHANGE: inputs with type `hidden` will be skipped by the `input-container`

Fixes angular#2153
@devversion devversion self-assigned this Mar 28, 2016
@devversion devversion added the pr: merge ready This PR is ready for a caretaker to review label Mar 28, 2016
ThomasBurleson pushed a commit that referenced this issue Apr 1, 2016
BREAKING CHANGE: inputs with type `hidden` will be skipped by the `input-container`

Fixes #2153

Closes #6425
ThomasBurleson pushed a commit that referenced this issue Apr 1, 2016
BREAKING CHANGE: inputs with type `hidden` will be skipped by the `input-container`

Fixes #2153

Closes #6425
gmoothart pushed a commit to gmoothart/material that referenced this issue Apr 5, 2016
BREAKING CHANGE: inputs with type `hidden` will be skipped by the `input-container`

Fixes angular#2153

Closes angular#6425
@Splaktar Splaktar removed this from the - Backlog milestone Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants