Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-slider does not work with too small float values in v0.10.1 #3259

Closed
Tooa opened this issue Jun 14, 2015 · 4 comments
Closed

md-slider does not work with too small float values in v0.10.1 #3259

Tooa opened this issue Jun 14, 2015 · 4 comments

Comments

@Tooa
Copy link

Tooa commented Jun 14, 2015

Hi,

See this for the problem. Dragging the slider will move it instantly to the right. In version 0.9.4 the slider works as expected. It seems that it is not working if the float values are too small.

Best Uli
@Tooa Tooa changed the title md-slider does not work with float values in v0.10.0-rc4-master-7b8efe2 md-slider does not work with float values in v0.10.0 Jun 15, 2015
@Tooa Tooa changed the title md-slider does not work with float values in v0.10.0 md-slider does not work with too small float values in v0.10.0 Jun 19, 2015
@Tooa
Copy link
Author

Tooa commented Jun 19, 2015

I traced down the introduced problem to this 476d068 commit. Because in version angular/bower-material@3d223b0 it is working and the above commits were the only new changes made since then. I also changed it back to the previous version and it's working! Rounding the actual value to three digits is not an optimal solution, because as you can see it doesn't work for smaller floats. The fix for #2015 is more like a workaround.

@ThomasBurleson ThomasBurleson modified the milestone: Backlog Jul 6, 2015
@Tooa
Copy link
Author

Tooa commented Aug 19, 2015

Hi,

I just wanted to ask what the status on this report is. The problem still exists in the current master branch (See: [1]). I also wonder why the label Backlog is assigned to this ticket:

Grouping for issues that have been reviewed and require further information before assignment to milestone is possible.

Which information is missing?

[1] http://plnkr.co/edit/RklobRPrAuehot9JevLm?p=preview

@Tooa Tooa changed the title md-slider does not work with too small float values in v0.10.0 md-slider does not work with too small float values in v0.10.1 Aug 20, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 0.12.0, Backlog Sep 4, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc1, 1.0-rc2, 1.0-rc3 Oct 27, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc3, 1.0-rc4 Nov 7, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc4, 1.0-rc5 Nov 16, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc5, 1.0-rc8 Nov 25, 2015
EladBezalel added a commit that referenced this issue Jan 4, 2016
@EladBezalel
feat(slider): vertical slider, UI fixes and bug fixes
97b7656 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Made value rounding to 6 zeros after the dot
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576
EladBezalel added a commit that referenced this issue Jan 4, 2016
@EladBezalel
feat(slider): vertical slider, UI fixes and bug fixes
f9554e0 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Made value rounding to 6 zeros after the dot
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576
@EladBezalel EladBezalel mentioned this issue Jan 4, 2016
Closed
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc8, 1.1.0, Backlog Jan 5, 2016
EladBezalel added a commit that referenced this issue Jan 10, 2016
@EladBezalel
feat(slider): vertical slider, UI fixes and bug fixes
1e37d5d 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Made value rounding to 6 zeros after the dot
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576
EladBezalel added a commit that referenced this issue Jan 29, 2016
@EladBezalel
feat(slider): vertical slider, UI fixes and bug fixes
d2ce2fa 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Made value rounding to 6 zeros after the dot
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576
EladBezalel added a commit that referenced this issue Jan 29, 2016
@EladBezalel
feat(slider): vertical slider, UI fixes and bug fixes
7173881 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Made value rounding to 6 zeros after the dot
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576
EladBezalel added a commit that referenced this issue Feb 4, 2016
@EladBezalel
feat(slider): vertical slider, UI fixes and bug fixes
0727cfc 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Made value rounding to 6 zeros after the dot
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576
closes #5874, #5872, #6051
EladBezalel added a commit that referenced this issue Feb 5, 2016
@EladBezalel
feat(slider): vertical slider, UI fixes and bug fixes
e04dd2c 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Made value rounding to 6 zeros after the dot
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576
closes #5874, #5872, #6051
EladBezalel added a commit that referenced this issue Feb 6, 2016
@EladBezalel
feat(slider): vertical slider, UI fixes and bug fixes
81bae90 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Made value rounding to 6 zeros after the dot
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576
closes #5874, #5872, #6051
EladBezalel added a commit that referenced this issue Feb 26, 2016
@EladBezalel
feat(slider): vertical slider, UI fixes and bug fixes
55673f4 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Made value rounding to 6 zeros after the dot
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576
closes #5874, #5872, #6051
EladBezalel added a commit that referenced this issue Feb 26, 2016
@EladBezalel
feat(slider): vertical slider, UI fixes and bug fixes
1692813 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Made value rounding to 6 zeros after the dot
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576, #6996
closes #5874, #5872, #6051
EladBezalel added a commit that referenced this issue Feb 26, 2016
@EladBezalel
feat(slider): vertical slider, UI fixes and bug fixes
4d4691a 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Made value rounding to 6 zeros after the dot
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576, #6996
closes #5874, #5872, #6051
EladBezalel added a commit that referenced this issue Feb 26, 2016
@EladBezalel
feat(slider): vertical slider, UI fixes and bug fixes
0f41386 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Made value rounding to 6 zeros after the dot
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576, #6996
closes #5874, #5872, #6051
EladBezalel added a commit that referenced this issue Feb 26, 2016
@EladBezalel
feat(slider): vertical slider, UI fixes and bug fixes
f1b7529 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Made value rounding to 6 zeros after the dot
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576, #6996
closes #5874, #5872, #6051
EladBezalel added a commit that referenced this issue Feb 27, 2016
@EladBezalel
feat(slider): vertical slider, UI fixes and bug fixes
c176251 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Added round attribute to set how many numbers should be after the dot, default is 3, maximum is 6 to prevent scientific notation.
- Made input width grow or shrink according the text length
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576, #6996, #7093, #7093
closes #5874, #5872, #6051
EladBezalel added a commit that referenced this issue Feb 27, 2016
@EladBezalel
feat(slider): vertical slider, UI fixes and bug fixes
914b35b 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Added round attribute to set how many numbers should be after the dot, default is 3, maximum is 6 to prevent scientific notation.
- Made input width grow or shrink according the text length
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576, #6996, #7093, #7093
closes #5874, #5872, #6051
ThomasBurleson pushed a commit that referenced this issue Mar 2, 2016
@EladBezalel @ThomasBurleson
feat(slider): vertical slider, UI fixes and bug fixes
e0abeb4 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Added round attribute to set how many numbers should be after the dot, default is 3, maximum is 6 to prevent scientific notation.
- Made input width grow or shrink according the text length
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576, #6996, #7093, #7093
closes #5874, #5872, #6051
@ThomasBurleson
Copy link
Contributor

Fixed with SHA e0abeb4

@ThomasBurleson ThomasBurleson removed the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Apr 25, 2016
@Splaktar Splaktar removed this from the - Backlog milestone Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ThomasBurleson @Splaktar @CarmenPopoviciu @Tooa @EladBezalel