Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-tooltip doesn't work on firefox 38.0.5 #3430

Closed
oscarr-reyes opened this issue Jun 24, 2015 · 20 comments
Closed

md-tooltip doesn't work on firefox 38.0.5 #3430

oscarr-reyes opened this issue Jun 24, 2015 · 20 comments
Assignees

Comments

@oscarr-reyes
Copy link

i am trying to make a button on toolbar to show a tooltip whenever the mouse hover on an icon button

<md-button class="md-icon-button" ng-href="#/cotizacion">
    <md-tooltip>Cotizacion</md-tooltip>
    <md-icon md-font-icon="fa fa-lg fa-pencil-square-o" aria-label="Cotizacion"></md-icon>
</md-button>

but it doesn nothing, even on click, i am using the lastest version 0.10.0

@xforceco
Copy link

It works, please try to follow the demo page, and ensure you have properly included angular-material.min.css, angular material icons, and angular-material.min.js

@oscarr-reyes
Copy link
Author

@xforceco the code is the same on the demo, and even the demo doesn't work for me, only if i check "insert dive" and i'm loading all libraries but yet it doesn't work, i am using firefox browser

@xforceco
Copy link

I see you intend to use font-awesome.
Have you included it properly?

https://material.angularjs.org/latest/#/api/material.components.icon/service/$mdIconProvider

And please provide a plunker for details, as I am sure at least for:

<md-button class="md-icon-button" ng-href="#/cotizacion">
    <md-tooltip>Cotizacion</md-tooltip>
    <md-icon></md-icon>
</md-button>

the tooltip is working in my codepen

@oscarr-reyes
Copy link
Author

@xforceco but why it doesnt work even in the demo?

@xforceco
Copy link

pr3

which demo page are you referring to?
tooltip works, but I am not sure whether your font-icon works

@oscarr-reyes
Copy link
Author

firefox version

i am still learning angular material and i have no idea how i would properly set the classes on $mdIconProvider

@oscarr-reyes
Copy link
Author

@xforceco on the demo, when you hover the button, does the tooltip work?

@xforceco
Copy link

@Nosthertus Yes, it is a screen capture when I hover on the button, so I don't understand why you said demo not working.

@oscarr-reyes
Copy link
Author

@xforceco because in my screen, the demo doesn't work, just when i click on "insert dive"

@sajmons
Copy link

sajmons commented Jun 24, 2015

I can confirm that in FireFox 38.0.5 hover tool-tips aren't working.

CodePen: http://codepen.io/anon/pen/RPjLzW

@Londovir
Copy link

Seems like some sort of odd Firefox issue. If you single step in Firefox, you hit a call to setVisible(true) buried in the method bindEvents for the md-tooltip. For Firefox, though, single stepping that line actually diverts you into createEventHandler/eventHandler of jqLiteOn, and eventually the method calls run out without the call to setVisible ever resolving. In fact, oddly enough, a single single-step action doesn't visibly do anything in Firefox developer tools, which is odd. I can't quite figure out what's happening with that. It's almost like that is trying to call setVisible but fails, for some reason.

In Chrome, BTW, that call to setVisible resolves instantly, and then it proceeds to the event handlers. Not sure why Firefox is getting pre-empted or ignoring the call to setVisible.

Note, though, that moving your cursor off the bound element (fab) IS triggering the setVisible(false) call properly.

@oscarr-reyes
Copy link
Author

@Londovir so, should i wait for the developers to see if they can fix this in another updated version?

@oscarr-reyes oscarr-reyes changed the title md-tooltip doesn't work md-tooltip doesn't work on firefox 38.0.5 Jun 24, 2015
@JDGoldman
Copy link

I have the same issue with Firefox 38.0.5 on the Angular Material Demo Page for md-tooltip:
md-tooltip screenshot

@Splaktar
Copy link
Member

This is already reproducible in the tooltip.spec.js tests. If Karma is run with Firefox 5 of the tests fail.

1a07051 does indeed fix the tests and causes them to pass on all browsers but it just breaks the check by using block instead of none. Something like dog or cat will also cause the tests to pass ;) Just removing the check appears to cleaner.

Splaktar added a commit to Splaktar/material that referenced this issue Jun 26, 2015
Remove check for pointer-events not equal to none to resolve non-visible tooltips on Firefox.
Add Chrome & Firefox as default test runners in karma task to avoid regressions like this in the future.

Closes angular#3047, angular#3250 and angular#3430
Splaktar added a commit to Splaktar/material that referenced this issue Jun 26, 2015
Remove check for pointer-events not equal to none to resolve non-visible tooltips on Firefox.
Add Chrome & Firefox as default test runners in karma task to avoid regressions like this in the future.

Closes angular#3047, angular#3250 and angular#3430
Splaktar added a commit that referenced this issue Jun 26, 2015
Remove check for pointer-events not equal to none to resolve non-visible tooltips on Firefox.
Add Chrome & Firefox as default test runners in karma task to avoid regressions like this in the future.

Closes #3047, #3250 and #3430
Splaktar added a commit that referenced this issue Jul 1, 2015
Remove check for pointer-events not equal to none to resolve non-visible tooltips on Firefox.
Add Chrome & Firefox as default test runners in karma task to avoid regressions like this in the future.

Closes #3047, #3250 and #3430
Splaktar added a commit that referenced this issue Jul 4, 2015
Remove check for pointer-events not equal to none to resolve non-visible tooltips on Firefox.
Add Chrome & Firefox as default test runners in karma task to avoid regressions like this in the future.
Improve and automate use of ngAnimateMock

Fixes #3047. Fixes #3250.  Fixes #3430. Closes #3467.
@Luxiyalu
Copy link

For the time being, use something like this to force the display:

<md-button class="md-fab md-accent" aria-label="Play" ng-mouseenter="show=true" ng-mouseleave="show=false">
  <md-tooltip md-visible="show">
    Play Music
  </md-tooltip>
</md-button>

@Splaktar Splaktar self-assigned this Jul 21, 2015
@danieladz
Copy link

I'm having the same issue with the tooltip also the icon in the button doesn't recognize any hover action for example color changing on hover...
@Luxiyalu I tried your way and it didn't work on firefox :(

@Splaktar
Copy link
Member

This should be working in 0.10.1-rc3.

As for the button hover behavior, I think that most button hover styles were removed a couple releases ago since they aren't in the spec (don't work on mobile).

@gilad905
Copy link

gilad905 commented Jul 13, 2016

I had the same problem (md-tooltip worked on Chrome but not on Firefox) and found out that this can be caused by placing md-tooltip as an indirect child of md-button. E.G:
<md-button id="reload-button" class="md-icon-button material-icons"> <span style="margin:auto"> refresh <md-tooltip>Reload</md-tooltip> </span> </md-button>

Instead of
<md-button id="reload-button" class="md-icon-button material-icons"> refresh <md-tooltip>Reload</md-tooltip> </md-button>

It actually makes sense that md-tooltip would be expected to be the direct child of md-button, but since in Chrome the 2nd case also works, this might be a cause for confusion among developers.

@naveenjafer
Copy link

In my case I have a Md-list element on which I am trying to create a tooltip. Works on chrome and safari but fails on firefox.

@ThomasBurleson
Copy link
Contributor

We support evergreen browsers n-1; Firefox v38 is not supported.

@angular angular locked and limited conversation to collaborators Jul 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests