Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-tabs: the label/body syntax does not work when inside another md-tabs #4989

Closed
amritk opened this issue Oct 2, 2015 · 2 comments
Closed
Assignees
Labels
pr: merge ready This PR is ready for a caretaker to review

Comments

@amritk
Copy link

amritk commented Oct 2, 2015

I found an issue using md-tabs within md-tabs using a specific syntax. When I use this syntax it works fine:

<!-- Finances tab -->
<md-tab label="Finance" md-on-select="$root.updateTabUrl('finance')" ng-if="true || gamesShow.resource.can_manage">
    <md-tabs md-no-bar md-stretch-tabs="always" class="inner-tabs">
        <md-tab label="Subtab-1">content</md-tab>
        <md-tab label="Subtab-2">more content</md-tab>
    </md-tabs>
</md-tab>

screen shot 2015-10-02 at 1 47 19 pm

But when I use the other syntax, so I can include icons in my inner tabs, it seems to add the inner tab to the parent tabs and replace the finance tab. This method was outlined in #3524

<!-- Finances tab -->
<md-tab label="Finance" md-on-select="$root.updateTabUrl('finance')" ng-if="true || gamesShow.resource.can_manage">
    <md-tabs md-no-bar md-stretch-tabs="always" class="inner-tabs">
       <md-tab>
    <md-tab-label>
        <md-icon md-font-library="material-icons">camera_alt</md-icon>
        Subtab-1
    </md-tab-label>
    <md-tab-body>
        content
    </md-tab-body>
</md-tab>
<md-tab>
    <md-tab-label>
        <md-icon md-font-library="material-icons">location_on</md-icon>
        Subtab-2
    </md-tab-label>
    <md-tab-body>
        more content
    </md-tab-body>
</md-tab>
    </md-tabs>
</md-tab>

screen shot 2015-10-02 at 1 50 57 pm

@robertmesserle
Copy link
Contributor

I believe this was resolved a while ago - please confirm.

@amritk
Copy link
Author

amritk commented Nov 3, 2015

@robertmesserle it actually still does not work

http://codepen.io/anon/pen/QjBYNP

@robertmesserle robertmesserle reopened this Nov 4, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc3, 1.0-rc4 Nov 7, 2015
@robertmesserle robertmesserle modified the milestones: post-1.0 , 1.0-rc4 Nov 13, 2015
robertmesserle pushed a commit that referenced this issue Nov 13, 2015
@robertmesserle robertmesserle added the pr: merge ready This PR is ready for a caretaker to review label Nov 13, 2015
robertmesserle pushed a commit that referenced this issue Nov 16, 2015
robertmesserle pushed a commit that referenced this issue Nov 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

No branches or pull requests

3 participants